Title: [265456] trunk/Source/WebKit
- Revision
- 265456
- Author
- [email protected]
- Date
- 2020-08-10 15:01:07 -0700 (Mon, 10 Aug 2020)
Log Message
Use RefPtr for WebKit::WebOpenPanelResultListenerProxy
<https://webkit.org/b/215252>
<rdar://problem/65753821>
Reviewed by Geoffrey Garen.
Unable to create an API test for this.
* UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::runOpenPanel):
- Use RefPtr<WebOpenPanelResultListenerProxy> when passing
`listener` into the block.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265455 => 265456)
--- trunk/Source/WebKit/ChangeLog 2020-08-10 21:51:58 UTC (rev 265455)
+++ trunk/Source/WebKit/ChangeLog 2020-08-10 22:01:07 UTC (rev 265456)
@@ -1,3 +1,18 @@
+2020-08-10 David Kilzer <[email protected]>
+
+ Use RefPtr for WebKit::WebOpenPanelResultListenerProxy
+ <https://webkit.org/b/215252>
+ <rdar://problem/65753821>
+
+ Reviewed by Geoffrey Garen.
+
+ Unable to create an API test for this.
+
+ * UIProcess/Cocoa/UIDelegate.mm:
+ (WebKit::UIDelegate::UIClient::runOpenPanel):
+ - Use RefPtr<WebOpenPanelResultListenerProxy> when passing
+ `listener` into the block.
+
2020-08-10 Wenson Hsieh <[email protected]>
Add more logging to diagnose editing/selection/ios/select-all-non-editable-text-using-keyboard.html
Modified: trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm (265455 => 265456)
--- trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm 2020-08-10 21:51:58 UTC (rev 265455)
+++ trunk/Source/WebKit/UIProcess/Cocoa/UIDelegate.mm 2020-08-10 22:01:07 UTC (rev 265456)
@@ -827,7 +827,7 @@
auto checker = CompletionHandlerCallChecker::create(delegate.get(), @selector(webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:));
- [delegate webView:m_uiDelegate.m_webView runOpenPanelWithParameters:wrapper(*openPanelParameters) initiatedByFrame:wrapper(frame) completionHandler:makeBlockPtr([checker = WTFMove(checker), openPanelParameters = makeRef(*openPanelParameters), listener = WTFMove(listener)] (NSArray *URLs) mutable {
+ [delegate webView:m_uiDelegate.m_webView runOpenPanelWithParameters:wrapper(*openPanelParameters) initiatedByFrame:wrapper(frame) completionHandler:makeBlockPtr([checker = WTFMove(checker), openPanelParameters = makeRef(*openPanelParameters), listener = makeRefPtr(listener)] (NSArray *URLs) mutable {
if (checker->completionHandlerHasBeenCalled())
return;
checker->didCallCompletionHandler();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
