Title: [265457] trunk/Source/WebCore
Revision
265457
Author
[email protected]
Date
2020-08-10 15:17:50 -0700 (Mon, 10 Aug 2020)

Log Message

MobileSafari crashes at WebCore: -[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]
https://bugs.webkit.org/show_bug.cgi?id=215332

Reviewed by Eric Carlson.

Add a NULL pointer check to fix a crash.

* platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (265456 => 265457)


--- trunk/Source/WebCore/ChangeLog	2020-08-10 22:01:07 UTC (rev 265456)
+++ trunk/Source/WebCore/ChangeLog	2020-08-10 22:17:50 UTC (rev 265457)
@@ -1,3 +1,15 @@
+2020-08-10  Peng Liu  <[email protected]>
+
+        MobileSafari crashes at WebCore: -[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]
+        https://bugs.webkit.org/show_bug.cgi?id=215332
+
+        Reviewed by Eric Carlson.
+
+        Add a NULL pointer check to fix a crash.
+
+        * platform/ios/WebAVPlayerController.mm:
+        (-[WebAVPlayerController seekToTime:toleranceBefore:toleranceAfter:]):
+
 2020-08-10  Myles C. Maxfield  <[email protected]>
 
         Shaping can be performed on glyphIDs from the wrong font

Modified: trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm (265456 => 265457)


--- trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2020-08-10 22:01:07 UTC (rev 265456)
+++ trunk/Source/WebCore/platform/ios/WebAVPlayerController.mm	2020-08-10 22:17:50 UTC (rev 265457)
@@ -185,7 +185,8 @@
 
 - (void)seekToTime:(NSTimeInterval)time toleranceBefore:(NSTimeInterval)before toleranceAfter:(NSTimeInterval)after
 {
-    self.delegate->seekToTime(time, before, after);
+    if (self.delegate)
+        self.delegate->seekToTime(time, before, after);
 }
 
 - (void)seekByTimeInterval:(NSTimeInterval)interval
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to