Title: [265650] trunk/Source/WebKit
- Revision
- 265650
- Author
- [email protected]
- Date
- 2020-08-13 23:01:44 -0700 (Thu, 13 Aug 2020)
Log Message
[GTK4] Notify the web process on drag leave
https://bugs.webkit.org/show_bug.cgi?id=215373
Reviewed by Adrian Perez de Castro.
We missed this when implemented drag and drop support for GTK4.
* UIProcess/API/gtk/DropTargetGtk4.cpp:
(WebKit::DropTarget::leave): Call dragExited() and resetCurrentDragInformation() on WebPageProxy.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265649 => 265650)
--- trunk/Source/WebKit/ChangeLog 2020-08-14 06:00:32 UTC (rev 265649)
+++ trunk/Source/WebKit/ChangeLog 2020-08-14 06:01:44 UTC (rev 265650)
@@ -1,5 +1,17 @@
2020-08-13 Carlos Garcia Campos <[email protected]>
+ [GTK4] Notify the web process on drag leave
+ https://bugs.webkit.org/show_bug.cgi?id=215373
+
+ Reviewed by Adrian Perez de Castro.
+
+ We missed this when implemented drag and drop support for GTK4.
+
+ * UIProcess/API/gtk/DropTargetGtk4.cpp:
+ (WebKit::DropTarget::leave): Call dragExited() and resetCurrentDragInformation() on WebPageProxy.
+
+2020-08-13 Carlos Garcia Campos <[email protected]>
+
[GTK] Do not accept drag operations when the matched target list is empty
https://bugs.webkit.org/show_bug.cgi?id=215372
Modified: trunk/Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp (265649 => 265650)
--- trunk/Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp 2020-08-14 06:00:32 UTC (rev 265649)
+++ trunk/Source/WebKit/UIProcess/API/gtk/DropTargetGtk4.cpp 2020-08-14 06:01:44 UTC (rev 265650)
@@ -290,6 +290,15 @@
void DropTarget::leave()
{
g_cancellable_cancel(m_cancellable.get());
+
+ auto* page = webkitWebViewBaseGetPage(WEBKIT_WEB_VIEW_BASE(m_webView));
+ ASSERT(page);
+
+ auto position = m_position.valueOr(IntPoint());
+ DragData dragData(&m_selectionData.value(), position, position, { });
+ page->dragExited(dragData);
+ page->resetCurrentDragInformation();
+
m_drop = nullptr;
m_position = WTF::nullopt;
m_selectionData = WTF::nullopt;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
