Title: [265652] releases/WebKitGTK/webkit-2.30/Source/WebKit
- Revision
- 265652
- Author
- [email protected]
- Date
- 2020-08-13 23:38:47 -0700 (Thu, 13 Aug 2020)
Log Message
Merge r265560 - WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
https://bugs.webkit.org/show_bug.cgi?id=215412
<rdar://problem/66296820>
Reviewed by Tim Horton.
Add a `MESSAGE_CHECK` to avoid ever creating a `WebEditCommandProxy` with an invalid command identifier.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerEditCommand):
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog (265651 => 265652)
--- releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog 2020-08-14 06:38:43 UTC (rev 265651)
+++ releases/WebKitGTK/webkit-2.30/Source/WebKit/ChangeLog 2020-08-14 06:38:47 UTC (rev 265652)
@@ -1,3 +1,16 @@
+2020-08-12 Wenson Hsieh <[email protected]>
+
+ WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
+ https://bugs.webkit.org/show_bug.cgi?id=215412
+ <rdar://problem/66296820>
+
+ Reviewed by Tim Horton.
+
+ Add a `MESSAGE_CHECK` to avoid ever creating a `WebEditCommandProxy` with an invalid command identifier.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::registerEditCommand):
+
2020-08-12 Carlos Garcia Campos <[email protected]>
REGRESSION(r261570): [GTK] Fails to send drop event to _javascript_
Modified: releases/WebKitGTK/webkit-2.30/Source/WebKit/UIProcess/WebPageProxy.cpp (265651 => 265652)
--- releases/WebKitGTK/webkit-2.30/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-08-14 06:38:43 UTC (rev 265651)
+++ releases/WebKitGTK/webkit-2.30/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-08-14 06:38:47 UTC (rev 265652)
@@ -6757,6 +6757,7 @@
void WebPageProxy::registerEditCommand(Ref<WebEditCommandProxy>&& commandProxy, UndoOrRedo undoOrRedo)
{
+ MESSAGE_CHECK(m_process, commandProxy->commandID());
pageClient().registerEditCommand(WTFMove(commandProxy), undoOrRedo);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
