Title: [265696] branches/safari-610.1-branch/Source/WebKit
- Revision
- 265696
- Author
- [email protected]
- Date
- 2020-08-14 12:48:39 -0700 (Fri, 14 Aug 2020)
Log Message
Cherry-pick r265560. rdar://problem/67084214
WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
https://bugs.webkit.org/show_bug.cgi?id=215412
<rdar://problem/66296820>
Reviewed by Tim Horton.
Add a `MESSAGE_CHECK` to avoid ever creating a `WebEditCommandProxy` with an invalid command identifier.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::registerEditCommand):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1-branch/Source/WebKit/ChangeLog (265695 => 265696)
--- branches/safari-610.1-branch/Source/WebKit/ChangeLog 2020-08-14 19:48:37 UTC (rev 265695)
+++ branches/safari-610.1-branch/Source/WebKit/ChangeLog 2020-08-14 19:48:39 UTC (rev 265696)
@@ -1,3 +1,34 @@
+2020-08-14 Alan Coon <[email protected]>
+
+ Cherry-pick r265560. rdar://problem/67084214
+
+ WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
+ https://bugs.webkit.org/show_bug.cgi?id=215412
+ <rdar://problem/66296820>
+
+ Reviewed by Tim Horton.
+
+ Add a `MESSAGE_CHECK` to avoid ever creating a `WebEditCommandProxy` with an invalid command identifier.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::registerEditCommand):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265560 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-08-12 Wenson Hsieh <[email protected]>
+
+ WebPageProxy::registerEditCommand should be robust against invalid undo step identifiers
+ https://bugs.webkit.org/show_bug.cgi?id=215412
+ <rdar://problem/66296820>
+
+ Reviewed by Tim Horton.
+
+ Add a `MESSAGE_CHECK` to avoid ever creating a `WebEditCommandProxy` with an invalid command identifier.
+
+ * UIProcess/WebPageProxy.cpp:
+ (WebKit::WebPageProxy::registerEditCommand):
+
2020-08-12 Alan Coon <[email protected]>
Cherry-pick r265515. rdar://problem/66943894
Modified: branches/safari-610.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp (265695 => 265696)
--- branches/safari-610.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-08-14 19:48:37 UTC (rev 265695)
+++ branches/safari-610.1-branch/Source/WebKit/UIProcess/WebPageProxy.cpp 2020-08-14 19:48:39 UTC (rev 265696)
@@ -6749,6 +6749,7 @@
void WebPageProxy::registerEditCommand(Ref<WebEditCommandProxy>&& commandProxy, UndoOrRedo undoOrRedo)
{
+ MESSAGE_CHECK(m_process, commandProxy->commandID());
pageClient().registerEditCommand(WTFMove(commandProxy), undoOrRedo);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
