Title: [265698] branches/safari-610.1-branch/Source/WebCore
- Revision
- 265698
- Author
- [email protected]
- Date
- 2020-08-14 12:48:45 -0700 (Fri, 14 Aug 2020)
Log Message
Cherry-pick r265581. rdar://problem/67083937
First search on Google Maps shows black bar at top of map and blank strips through the middle
https://bugs.webkit.org/show_bug.cgi?id=214945
<rdar://problem/63374422>
Reviewed by Tim Horton.
On iOS with an attached keyboard, Google Maps appears to calculate
the viewport it will use for map display at a time when the Unified
Control Bar (keyboard accessories) is visible. If it then changes the
map location via the user submitting a search form, the resulting map
will be using the incorrect viewport as the control bar has disappeared.
This causes parts of the map display to get the wrong stencil masks, leaving
blank strips. This fixes itself as soon as you force the map to recalculate
its viewport (e.g. by rotating the device).
Rather than have Google Maps update its code to detect these viewport changes,
we're adding a Quirk to not use the control bar in these calculations.
* page/Quirks.cpp:
(WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
Return true for "*.google.com/maps/".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-610.1-branch/Source/WebCore/ChangeLog (265697 => 265698)
--- branches/safari-610.1-branch/Source/WebCore/ChangeLog 2020-08-14 19:48:42 UTC (rev 265697)
+++ branches/safari-610.1-branch/Source/WebCore/ChangeLog 2020-08-14 19:48:45 UTC (rev 265698)
@@ -1,5 +1,57 @@
2020-08-14 Alan Coon <[email protected]>
+ Cherry-pick r265581. rdar://problem/67083937
+
+ First search on Google Maps shows black bar at top of map and blank strips through the middle
+ https://bugs.webkit.org/show_bug.cgi?id=214945
+ <rdar://problem/63374422>
+
+ Reviewed by Tim Horton.
+
+ On iOS with an attached keyboard, Google Maps appears to calculate
+ the viewport it will use for map display at a time when the Unified
+ Control Bar (keyboard accessories) is visible. If it then changes the
+ map location via the user submitting a search form, the resulting map
+ will be using the incorrect viewport as the control bar has disappeared.
+ This causes parts of the map display to get the wrong stencil masks, leaving
+ blank strips. This fixes itself as soon as you force the map to recalculate
+ its viewport (e.g. by rotating the device).
+
+ Rather than have Google Maps update its code to detect these viewport changes,
+ we're adding a Quirk to not use the control bar in these calculations.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
+ Return true for "*.google.com/maps/".
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@265581 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2020-08-12 Dean Jackson <[email protected]>
+
+ First search on Google Maps shows black bar at top of map and blank strips through the middle
+ https://bugs.webkit.org/show_bug.cgi?id=214945
+ <rdar://problem/63374422>
+
+ Reviewed by Tim Horton.
+
+ On iOS with an attached keyboard, Google Maps appears to calculate
+ the viewport it will use for map display at a time when the Unified
+ Control Bar (keyboard accessories) is visible. If it then changes the
+ map location via the user submitting a search form, the resulting map
+ will be using the incorrect viewport as the control bar has disappeared.
+ This causes parts of the map display to get the wrong stencil masks, leaving
+ blank strips. This fixes itself as soon as you force the map to recalculate
+ its viewport (e.g. by rotating the device).
+
+ Rather than have Google Maps update its code to detect these viewport changes,
+ we're adding a Quirk to not use the control bar in these calculations.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::shouldAvoidResizingWhenInputViewBoundsChange const):
+ Return true for "*.google.com/maps/".
+
+2020-08-14 Alan Coon <[email protected]>
+
Cherry-pick r265510. rdar://problem/67084518
Deferred WKUserScripts are exponentially injected on preloaded pages with frames.
Modified: branches/safari-610.1-branch/Source/WebCore/page/Quirks.cpp (265697 => 265698)
--- branches/safari-610.1-branch/Source/WebCore/page/Quirks.cpp 2020-08-14 19:48:42 UTC (rev 265697)
+++ branches/safari-610.1-branch/Source/WebCore/page/Quirks.cpp 2020-08-14 19:48:45 UTC (rev 265698)
@@ -493,7 +493,9 @@
if (!needsQuirks())
return false;
- auto host = m_document->topDocument().url().host();
+ auto& url = ""
+ auto host = url.host();
+
if (equalLettersIgnoringASCIICase(host, "live.com") || host.endsWithIgnoringASCIICase(".live.com"))
return true;
@@ -500,6 +502,9 @@
if (equalLettersIgnoringASCIICase(host, "twitter.com") || host.endsWithIgnoringASCIICase(".twitter.com"))
return true;
+ if ((equalLettersIgnoringASCIICase(host, "google.com") || host.endsWithIgnoringASCIICase(".google.com")) && url.path().startsWithIgnoringASCIICase("/maps/"))
+ return true;
+
if (host.endsWithIgnoringASCIICase(".sharepoint.com"))
return true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
