Title: [265750] trunk/Tools
Revision
265750
Author
[email protected]
Date
2020-08-17 00:38:30 -0700 (Mon, 17 Aug 2020)

Log Message

Update W3C test exporter to use Authorisation header instead of query parameter to validate GitHub account
https://bugs.webkit.org/show_bug.cgi?id=215548

Reviewed by Darin Adler.

* Scripts/webkitpy/w3c/test_exporter.py:
(WebPlatformTestExporter._validate_and_save_token):
access_token query parameter is dbeing deprecated in favor of Authorization header.
Update script accordingly.

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (265749 => 265750)


--- trunk/Tools/ChangeLog	2020-08-17 07:37:12 UTC (rev 265749)
+++ trunk/Tools/ChangeLog	2020-08-17 07:38:30 UTC (rev 265750)
@@ -1,3 +1,15 @@
+2020-08-17  Youenn Fablet  <[email protected]>
+
+        Update W3C test exporter to use Authorisation header instead of query parameter to validate GitHub account
+        https://bugs.webkit.org/show_bug.cgi?id=215548
+
+        Reviewed by Darin Adler.
+
+        * Scripts/webkitpy/w3c/test_exporter.py:
+        (WebPlatformTestExporter._validate_and_save_token):
+        access_token query parameter is dbeing deprecated in favor of Authorization header.
+        Update script accordingly.
+
 2020-08-15  Tim Horton  <[email protected]>
 
         Live Web Content processes do not respect accent color if dynamically changed to "multicolor"

Modified: trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py (265749 => 265750)


--- trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py	2020-08-17 07:37:12 UTC (rev 265749)
+++ trunk/Tools/Scripts/webkitpy/w3c/test_exporter.py	2020-08-17 07:38:30 UTC (rev 265750)
@@ -235,9 +235,10 @@
             self._validate_and_save_token(self._username, self._token)
 
     def _validate_and_save_token(self, username, token):
-        url = '' % (token,)
+        url = ''
+        headers = {'Accept': 'application/vnd.github.v3+json', 'Authorization': 'token {}'.format(token)}
         try:
-            response = self._host.web.request(method='GET', url="" data=""
+            response = self._host.web.request(method='GET', url="" data="" headers=headers)
         except HTTPError as e:
             raise Exception("OAuth token is not valid")
         data = ""
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to