Title: [265751] trunk/Source/WebKit
- Revision
- 265751
- Author
- [email protected]
- Date
- 2020-08-17 04:04:35 -0700 (Mon, 17 Aug 2020)
Log Message
REGRESSION(r265725) [GTK][WPE] Several http/tests timeout/failures
https://bugs.webkit.org/show_bug.cgi?id=215542
Patch by Carlos Garcia Campos <[email protected]> on 2020-08-17
Reviewed by Sergio Villar Senin.
The problem is that ShareableResource is now using the dataSize member of IPCHandle to encode/decode the
resource size, but SharedMemoryUnix is not encoding/decoding dataSize.
* Platform/unix/SharedMemoryUnix.cpp:
(WebKit::SharedMemory::IPCHandle::encode const):
(WebKit::SharedMemory::IPCHandle::decode):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (265750 => 265751)
--- trunk/Source/WebKit/ChangeLog 2020-08-17 07:38:30 UTC (rev 265750)
+++ trunk/Source/WebKit/ChangeLog 2020-08-17 11:04:35 UTC (rev 265751)
@@ -1,3 +1,17 @@
+2020-08-17 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r265725) [GTK][WPE] Several http/tests timeout/failures
+ https://bugs.webkit.org/show_bug.cgi?id=215542
+
+ Reviewed by Sergio Villar Senin.
+
+ The problem is that ShareableResource is now using the dataSize member of IPCHandle to encode/decode the
+ resource size, but SharedMemoryUnix is not encoding/decoding dataSize.
+
+ * Platform/unix/SharedMemoryUnix.cpp:
+ (WebKit::SharedMemory::IPCHandle::encode const):
+ (WebKit::SharedMemory::IPCHandle::decode):
+
2020-08-14 Simon Fraser <[email protected]>
Scrolling sync changes in r261985 regressed CPU usage by ~2 ms/s
Modified: trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp (265750 => 265751)
--- trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2020-08-17 07:38:30 UTC (rev 265750)
+++ trunk/Source/WebKit/Platform/unix/SharedMemoryUnix.cpp 2020-08-17 11:04:35 UTC (rev 265751)
@@ -75,6 +75,7 @@
void SharedMemory::IPCHandle::encode(IPC::Encoder& encoder) const
{
encoder << handle.releaseAttachment();
+ encoder << dataSize;
}
bool SharedMemory::IPCHandle::decode(IPC::Decoder& decoder, IPCHandle& ipcHandle)
@@ -84,7 +85,12 @@
if (!decoder.decode(attachment))
return false;
+ uint64_t dataSize;
+ if (!decoder.decode(dataSize))
+ return false;
+
ipcHandle.handle.adoptAttachment(WTFMove(attachment));
+ ipcHandle.dataSize = dataSize;
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
