Title: [266225] trunk/Source
- Revision
- 266225
- Author
- [email protected]
- Date
- 2020-08-26 23:46:54 -0700 (Wed, 26 Aug 2020)
Log Message
Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled
https://bugs.webkit.org/show_bug.cgi?id=215828
Reviewed by Devin Rousso.
Source/WebCore:
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::inspectInspector):
Explicitly set DeveloperExtrasEnabled for the Inspector
web view so that the Inspect context menu appears and
so the [2] button works as expected.
Source/WebInspectorUI:
Drive-by: because the Inspector^2 button is text-only and has no
.name element, the '2' button does not become dimmed when the
window is inactive, unlike every other item in the tab bar.
Fix this by coloring the text-only button similar to tab labels.
* UserInterface/Debug/Bootstrap.css:
(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only):
(.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover):
(.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected):
(body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected >):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (266224 => 266225)
--- trunk/Source/WebCore/ChangeLog 2020-08-27 05:43:04 UTC (rev 266224)
+++ trunk/Source/WebCore/ChangeLog 2020-08-27 06:46:54 UTC (rev 266225)
@@ -1,3 +1,15 @@
+2020-08-26 Brian Burg <[email protected]>
+ Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=215828
+
+ Reviewed by Devin Rousso.
+
+ * inspector/InspectorFrontendHost.cpp:
+ (WebCore::InspectorFrontendHost::inspectInspector):
+ Explicitly set DeveloperExtrasEnabled for the Inspector
+ web view so that the Inspect context menu appears and
+ so the [2] button works as expected.
+
2020-08-26 Zalan Bujtas <[email protected]>
[LFC][IFC] LineBuilder should not align the runs
Modified: trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp (266224 => 266225)
--- trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2020-08-27 05:43:04 UTC (rev 266224)
+++ trunk/Source/WebCore/inspector/InspectorFrontendHost.cpp 2020-08-27 06:46:54 UTC (rev 266225)
@@ -546,8 +546,10 @@
void InspectorFrontendHost::inspectInspector()
{
- if (m_frontendPage)
+ if (m_frontendPage) {
+ m_frontendPage->settings().setDeveloperExtrasEnabled(true);
m_frontendPage->inspectorController().show();
+ }
}
bool InspectorFrontendHost::isBeingInspected()
Modified: trunk/Source/WebInspectorUI/ChangeLog (266224 => 266225)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-08-27 05:43:04 UTC (rev 266224)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-08-27 06:46:54 UTC (rev 266225)
@@ -1,3 +1,22 @@
+2020-08-26 Brian Burg <[email protected]>
+
+ Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled
+ https://bugs.webkit.org/show_bug.cgi?id=215828
+
+ Reviewed by Devin Rousso.
+
+ Drive-by: because the Inspector^2 button is text-only and has no
+ .name element, the '2' button does not become dimmed when the
+ window is inactive, unlike every other item in the tab bar.
+ Fix this by coloring the text-only button similar to tab labels.
+
+ * UserInterface/Debug/Bootstrap.css:
+ (body.window-inactive .tab-bar > .navigation-bar .item.button.text-only):
+ (.tab-bar > .navigation-bar .item.button.text-only):
+ (.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover):
+ (.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected):
+ (body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected >):
+
2020-08-26 Devin Rousso <[email protected]>
Web Inspector: REGRESSION(r266074): cannot edit _javascript_ breakpoints
Modified: trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css (266224 => 266225)
--- trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css 2020-08-27 05:43:04 UTC (rev 266224)
+++ trunk/Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css 2020-08-27 06:46:54 UTC (rev 266225)
@@ -36,3 +36,23 @@
.tab-bar > .navigation-bar .inspect-inspector {
width: 1em !important;
}
+
+/* These rules are adapted from TabBar.css and are expected to match. */
+body.window-inactive .tab-bar > .navigation-bar .item.button.text-only {
+ color: hsla(0, 0%, var(--foreground-lightness), 0.4);
+}
+.tab-bar > .navigation-bar .item.button.text-only {
+ color: hsla(0, 0%, var(--foreground-lightness), 0.6);
+}
+
+.tab-bar > .navigation-bar .item.button.text-only:not(.selected):hover {
+ color: hsla(0, 0%, var(--foreground-lightness), 0.7);
+}
+
+.tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected {
+ color: hsla(0, 0%, var(--foreground-lightness), 0.8);
+}
+
+body.window-inactive .tab-bar > .navigation-bar .item.button.text-only:not(.disabled).selected > {
+ color: hsla(0, 0%, var(--foreground-lightness), 0.5);
+}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
