Title: [266226] trunk/Source/WebCore
- Revision
- 266226
- Author
- [email protected]
- Date
- 2020-08-27 01:25:23 -0700 (Thu, 27 Aug 2020)
Log Message
Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode
https://bugs.webkit.org/show_bug.cgi?id=215878
Reviewed by Youenn Fablet.
Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode, only
one of the enum values is ever used.
No new tests, no web-facing behavior change.
* Modules/webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::startLater):
(WebCore::AudioBufferSourceNode::startPlaying):
* Modules/webaudio/AudioBufferSourceNode.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (266225 => 266226)
--- trunk/Source/WebCore/ChangeLog 2020-08-27 06:46:54 UTC (rev 266225)
+++ trunk/Source/WebCore/ChangeLog 2020-08-27 08:25:23 UTC (rev 266226)
@@ -1,3 +1,20 @@
+2020-08-27 Chris Dumez <[email protected]>
+
+ Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode
+ https://bugs.webkit.org/show_bug.cgi?id=215878
+
+ Reviewed by Youenn Fablet.
+
+ Drop unnecessary BufferPlaybackMode enum from AudioBufferSourceNode, only
+ one of the enum values is ever used.
+
+ No new tests, no web-facing behavior change.
+
+ * Modules/webaudio/AudioBufferSourceNode.cpp:
+ (WebCore::AudioBufferSourceNode::startLater):
+ (WebCore::AudioBufferSourceNode::startPlaying):
+ * Modules/webaudio/AudioBufferSourceNode.h:
+
2020-08-26 Brian Burg <[email protected]>
Web Inspector: button for Inspector^2 doesn't work without setting default for DeveloperExtrasEnabled
https://bugs.webkit.org/show_bug.cgi?id=215828
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp (266225 => 266226)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2020-08-27 06:46:54 UTC (rev 266225)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.cpp 2020-08-27 08:25:23 UTC (rev 266226)
@@ -471,10 +471,10 @@
else if (buffer())
grainDuration = buffer()->duration() - grainOffset;
- return startPlaying(Partial, when, grainOffset, grainDuration);
+ return startPlaying(when, grainOffset, grainDuration);
}
-ExceptionOr<void> AudioBufferSourceNode::startPlaying(BufferPlaybackMode playbackMode, double when, double grainOffset, double grainDuration)
+ExceptionOr<void> AudioBufferSourceNode::startPlaying(double when, double grainOffset, double grainDuration)
{
ASSERT(isMainThread());
ALWAYS_LOG(LOGIDENTIFIER, "when = ", when, ", offset = ", grainOffset, ", duration = ", grainDuration);
@@ -493,7 +493,7 @@
if (!std::isfinite(grainDuration) || (grainDuration < 0))
return Exception { RangeError, "duration value should be positive"_s };
- m_isGrain = playbackMode == Partial;
+ m_isGrain = true;
m_grainOffset = grainOffset;
m_grainDuration = grainDuration;
m_startTime = when;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h (266225 => 266226)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2020-08-27 06:46:54 UTC (rev 266225)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.h 2020-08-27 08:25:23 UTC (rev 266226)
@@ -99,13 +99,8 @@
virtual double legacyGainValue() const { return 1.0; }
virtual bool shouldThrowOnAttemptToOverwriteBuffer() const { return true; }
- enum BufferPlaybackMode {
- Entire,
- Partial
- };
+ ExceptionOr<void> startPlaying(double when, double grainOffset, double grainDuration);
- ExceptionOr<void> startPlaying(BufferPlaybackMode, double when, double grainOffset, double grainDuration);
-
// Returns true on success.
bool renderFromBuffer(AudioBus*, unsigned destinationFrameOffset, size_t numberOfFrames, double startFrameOffset);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
