Title: [267027] trunk/Source
Revision
267027
Author
[email protected]
Date
2020-09-14 11:54:36 -0700 (Mon, 14 Sep 2020)

Log Message

Enable WebGL2 by default
https://bugs.webkit.org/show_bug.cgi?id=216464
<rdar://problem/68811378>

Reviewed by Sam Weinig.

Our WebGL2 implementation is in good enough shape that we should
enable it by default for broader testing.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:

Source/WebKit:

Remove "defaultWebGL2Enabled" since it wasn't being used anywhere.

* Shared/WebPreferences.yaml:
* Shared/WebPreferencesDefaultValues.cpp:
(WebKit::defaultWebGL2Enabled): Deleted.
* Shared/WebPreferencesDefaultValues.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (267026 => 267027)


--- trunk/Source/WebCore/ChangeLog	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebCore/ChangeLog	2020-09-14 18:54:36 UTC (rev 267027)
@@ -1,3 +1,16 @@
+2020-09-14  Dean Jackson  <[email protected]>
+
+        Enable WebGL2 by default
+        https://bugs.webkit.org/show_bug.cgi?id=216464
+        <rdar://problem/68811378>
+
+        Reviewed by Sam Weinig.
+
+        Our WebGL2 implementation is in good enough shape that we should
+        enable it by default for broader testing.
+
+        * page/RuntimeEnabledFeatures.h:
+
 2020-09-14  Zalan Bujtas  <[email protected]>
 
         [LFC][FFC] Introduce flex formatting context

Modified: trunk/Source/WebCore/page/RuntimeEnabledFeatures.h (267026 => 267027)


--- trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebCore/page/RuntimeEnabledFeatures.h	2020-09-14 18:54:36 UTC (rev 267027)
@@ -386,7 +386,7 @@
     bool m_isTransformStreamAPIEnabled { false };
 
 #if ENABLE(WEBGL2)
-    bool m_isWebGL2Enabled { false };
+    bool m_isWebGL2Enabled { true };
 #endif
 
 #if ENABLE(WEBGPU)

Modified: trunk/Source/WebKit/ChangeLog (267026 => 267027)


--- trunk/Source/WebKit/ChangeLog	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKit/ChangeLog	2020-09-14 18:54:36 UTC (rev 267027)
@@ -1,3 +1,21 @@
+2020-09-14  Dean Jackson  <[email protected]>
+
+        Enable WebGL2 by default
+        https://bugs.webkit.org/show_bug.cgi?id=216464
+        <rdar://problem/68811378>
+
+        Reviewed by Sam Weinig.
+
+        Our WebGL2 implementation is in good enough shape that we should
+        enable it by default for broader testing.
+
+        Remove "defaultWebGL2Enabled" since it wasn't being used anywhere.
+
+        * Shared/WebPreferences.yaml:
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultWebGL2Enabled): Deleted.
+        * Shared/WebPreferencesDefaultValues.h:
+
 2020-09-14  Youenn Fablet  <[email protected]>
 
         RemoteAudioMediaStreamTrackRenderer should process its IPC messages from a background thread

Modified: trunk/Source/WebKit/Shared/WebPreferences.yaml (267026 => 267027)


--- trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKit/Shared/WebPreferences.yaml	2020-09-14 18:54:36 UTC (rev 267027)
@@ -1455,7 +1455,7 @@
 
 WebGL2Enabled:
   type: bool
-  defaultValue: false
+  defaultValue: true
   humanReadableName: "WebGL 2.0"
   humanReadableDescription: "WebGL 2 prototype"
   category: experimental

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp (267026 => 267027)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp	2020-09-14 18:54:36 UTC (rev 267027)
@@ -184,19 +184,6 @@
 
 #endif // ENABLE(WEB_RTC)
 
-#if ENABLE(WEBGL2)
-
-bool defaultWebGL2Enabled()
-{
-#if HAVE(SYSTEM_FEATURE_FLAGS)
-    return isFeatureFlagEnabled("WebGL2");
-#endif
-
-    return false;
-}
-
-#endif // ENABLE(WEBGL2)
-
 #if ENABLE(WEBGPU)
 
 bool defaultWebGPUEnabled()

Modified: trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h (267026 => 267027)


--- trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.h	2020-09-14 18:54:36 UTC (rev 267027)
@@ -350,10 +350,6 @@
 bool defaultWebRTCCodecsInGPUProcess();
 #endif
 
-#if ENABLE(WEBGL2)
-bool defaultWebGL2Enabled();
-#endif
-
 #if ENABLE(WEBGPU)
 bool defaultWebGPUEnabled();
 #endif

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (267026 => 267027)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2020-09-14 18:54:36 UTC (rev 267027)
@@ -1,3 +1,17 @@
+2020-09-14  Dean Jackson  <[email protected]>
+
+        Enable WebGL2 by default
+        https://bugs.webkit.org/show_bug.cgi?id=216464
+        <rdar://problem/68811378>
+
+        Reviewed by Sam Weinig.
+
+        Our WebGL2 implementation is in good enough shape that we should
+        enable it by default for broader testing.
+
+        * WebView/WebPreferences.mm:
+        (+[WebPreferences initialize]):
+
 2020-09-10  Chris Dumez  <[email protected]>
 
         Unreviewed, reverting r266842 and r266883.

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (267026 => 267027)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-09-14 18:47:05 UTC (rev 267026)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2020-09-14 18:54:36 UTC (rev 267027)
@@ -642,7 +642,7 @@
         @YES, WebKitLayoutFormattingContextIntegrationEnabledPreferenceKey,
 
 #if ENABLE(WEBGL2)
-        @NO, WebKitWebGL2EnabledPreferenceKey,
+        @YES, WebKitWebGL2EnabledPreferenceKey,
 #endif
 #if ENABLE(WEBGPU)
         @NO, WebKitWebGPUEnabledPreferenceKey,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to