Title: [267028] trunk/Source/_javascript_Core
- Revision
- 267028
- Author
- [email protected]
- Date
- 2020-09-14 12:30:11 -0700 (Mon, 14 Sep 2020)
Log Message
Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
https://bugs.webkit.org/show_bug.cgi?id=216486
Reviewed by Joseph Pecoraro.
* inspector/InspectorBackendDispatcher.h:
* inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::sendResponse):
Add back overloads removed in r266885 so that the symbols exist.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (267027 => 267028)
--- trunk/Source/_javascript_Core/ChangeLog 2020-09-14 18:54:36 UTC (rev 267027)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-09-14 19:30:11 UTC (rev 267028)
@@ -1,3 +1,15 @@
+2020-09-14 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r266885): dyld: Symbol not found: __ZN9Inspector17BackendDispatcher12sendResponseElON3WTF6RefPtrINS1_8JSONImpl6ObjectENS1_13DumbPtrTraitsIS4_EEEEb
+ https://bugs.webkit.org/show_bug.cgi?id=216486
+
+ Reviewed by Joseph Pecoraro.
+
+ * inspector/InspectorBackendDispatcher.h:
+ * inspector/InspectorBackendDispatcher.cpp:
+ (Inspector::BackendDispatcher::sendResponse):
+ Add back overloads removed in r266885 so that the symbols exist.
+
2020-09-14 Saam Barati <[email protected]>
Don't assume byte code operands are uint32 JSValues
Modified: trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.cpp (267027 => 267028)
--- trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.cpp 2020-09-14 18:54:36 UTC (rev 267027)
+++ trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.cpp 2020-09-14 19:30:11 UTC (rev 267028)
@@ -188,6 +188,20 @@
}
// FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
+void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result)
+{
+ ASSERT(result);
+ sendResponse(requestId, result.releaseNonNull(), false);
+}
+
+// FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
+void BackendDispatcher::sendResponse(long requestId, RefPtr<JSON::Object>&& result, bool)
+{
+ ASSERT(result);
+ sendResponse(requestId, result.releaseNonNull(), false);
+}
+
+// FIXME: remove this function when legacy InspectorObject symbols are no longer needed <http://webkit.org/b/179847>.
void BackendDispatcher::sendResponse(long requestId, Ref<JSON::Object>&& result)
{
sendResponse(requestId, WTFMove(result), false);
Modified: trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.h (267027 => 267028)
--- trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.h 2020-09-14 18:54:36 UTC (rev 267027)
+++ trunk/Source/_javascript_Core/inspector/InspectorBackendDispatcher.h 2020-09-14 19:30:11 UTC (rev 267028)
@@ -89,8 +89,10 @@
// Note that 'unused' is a workaround so the compiler can pick the right sendResponse based on arity.
// When <http://webkit.org/b/179847> is fixed or this class is renamed for the JSON::Object case,
// then this alternate method with a dummy parameter can be removed in favor of the one without it.
+ void sendResponse(long requestId, RefPtr<JSON::Object>&& result);
+ void sendResponse(long requestId, RefPtr<JSON::Object>&& result, bool unused);
+ void sendResponse(long requestId, Ref<JSON::Object>&& result);
void sendResponse(long requestId, Ref<JSON::Object>&& result, bool unused);
- void sendResponse(long requestId, Ref<JSON::Object>&& result);
void sendPendingErrors();
void reportProtocolError(CommonErrorCode, const String& errorMessage);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
