Title: [267464] trunk/Source/WebCore
Revision
267464
Author
[email protected]
Date
2020-09-22 21:47:42 -0700 (Tue, 22 Sep 2020)

Log Message

Web Inspector: Change `InspectorAnimationAgent->startTracking` to not error on repeated calls
https://bugs.webkit.org/show_bug.cgi?id=216385

Patch by Patrick Angle <[email protected]> on 2020-09-22
Reviewed by Devin Rousso.

InpsectorAnimationAgent now mirrors the behavior of other timeline agents by no longer returning an error on a
repeated invocation of `startTracking`.

* inspector/agents/InspectorAnimationAgent.cpp:
(WebCore::InspectorAnimationAgent::startTracking):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (267463 => 267464)


--- trunk/Source/WebCore/ChangeLog	2020-09-23 04:39:06 UTC (rev 267463)
+++ trunk/Source/WebCore/ChangeLog	2020-09-23 04:47:42 UTC (rev 267464)
@@ -1,3 +1,16 @@
+2020-09-22  Patrick Angle  <[email protected]>
+
+        Web Inspector: Change `InspectorAnimationAgent->startTracking` to not error on repeated calls
+        https://bugs.webkit.org/show_bug.cgi?id=216385
+
+        Reviewed by Devin Rousso.
+
+        InpsectorAnimationAgent now mirrors the behavior of other timeline agents by no longer returning an error on a
+        repeated invocation of `startTracking`.
+
+        * inspector/agents/InspectorAnimationAgent.cpp:
+        (WebCore::InspectorAnimationAgent::startTracking):
+
 2020-09-22  Antti Koivisto  <[email protected]>
 
         [LFC][Integration] Basic pagination support

Modified: trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp (267463 => 267464)


--- trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp	2020-09-23 04:39:06 UTC (rev 267463)
+++ trunk/Source/WebCore/inspector/agents/InspectorAnimationAgent.cpp	2020-09-23 04:47:42 UTC (rev 267464)
@@ -340,7 +340,7 @@
 Protocol::ErrorStringOr<void> InspectorAnimationAgent::startTracking()
 {
     if (m_instrumentingAgents.trackingAnimationAgent() == this)
-        return makeUnexpected("Animation domain already tracking"_s);
+        return { };
 
     m_instrumentingAgents.setTrackingAnimationAgent(this);
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to