Title: [267465] trunk/Source/WebCore
- Revision
- 267465
- Author
- [email protected]
- Date
- 2020-09-23 00:57:26 -0700 (Wed, 23 Sep 2020)
Log Message
[LFC][IFC] Remove redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled from Line::Run::hasTrailingLetterSpacing
https://bugs.webkit.org/show_bug.cgi?id=216867
Reviewed by Simon Fraser.
This codepath is only triggered when Line::TrimmableTrailingContent has a partially trimmable run.
However we don't add such runs unless m_shouldIgnoreTrailingLetterSpacing is false (which is already based on the RuntimeEnabledFeatures flag).
* layout/inlineformatting/InlineLine.cpp:
(WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
(WebCore::Layout::Line::Run::trailingLetterSpacing const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (267464 => 267465)
--- trunk/Source/WebCore/ChangeLog 2020-09-23 04:47:42 UTC (rev 267464)
+++ trunk/Source/WebCore/ChangeLog 2020-09-23 07:57:26 UTC (rev 267465)
@@ -1,3 +1,17 @@
+2020-09-23 Zalan Bujtas <[email protected]>
+
+ [LFC][IFC] Remove redundant RuntimeEnabledFeatures::layoutFormattingContextIntegrationEnabled from Line::Run::hasTrailingLetterSpacing
+ https://bugs.webkit.org/show_bug.cgi?id=216867
+
+ Reviewed by Simon Fraser.
+
+ This codepath is only triggered when Line::TrimmableTrailingContent has a partially trimmable run.
+ However we don't add such runs unless m_shouldIgnoreTrailingLetterSpacing is false (which is already based on the RuntimeEnabledFeatures flag).
+
+ * layout/inlineformatting/InlineLine.cpp:
+ (WebCore::Layout::Line::Run::hasTrailingLetterSpacing const):
+ (WebCore::Layout::Line::Run::trailingLetterSpacing const):
+
2020-09-22 Patrick Angle <[email protected]>
Web Inspector: Change `InspectorAnimationAgent->startTracking` to not error on repeated calls
Modified: trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp (267464 => 267465)
--- trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2020-09-23 04:47:42 UTC (rev 267464)
+++ trunk/Source/WebCore/layout/inlineformatting/InlineLine.cpp 2020-09-23 07:57:26 UTC (rev 267465)
@@ -497,9 +497,6 @@
bool Line::Run::hasTrailingLetterSpacing() const
{
- // Complex line layout does not keep track of trailing letter spacing.
- if (RuntimeEnabledFeatures::sharedFeatures().layoutFormattingContextIntegrationEnabled())
- return false;
return !hasTrailingWhitespace() && style().letterSpacing() > 0;
}
@@ -506,7 +503,7 @@
InlineLayoutUnit Line::Run::trailingLetterSpacing() const
{
if (!hasTrailingLetterSpacing())
- return 0_lu;
+ return { };
return InlineLayoutUnit { style().letterSpacing() };
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
