Title: [269071] trunk/Source/WebInspectorUI
- Revision
- 269071
- Author
- [email protected]
- Date
- 2020-10-27 14:38:15 -0700 (Tue, 27 Oct 2020)
Log Message
Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
https://bugs.webkit.org/show_bug.cgi?id=218254
Reviewed by Joseph Pecoraro.
r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
`WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype._domTreeElementAdded):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (269070 => 269071)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-10-27 21:04:15 UTC (rev 269070)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-10-27 21:38:15 UTC (rev 269071)
@@ -1,3 +1,16 @@
+2020-10-27 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(r266669): Uncaught Exception: TypeError: node.nodeType is not a function. (In 'node.nodeType()', 'node.nodeType' is undefined)
+ https://bugs.webkit.org/show_bug.cgi?id=218254
+
+ Reviewed by Joseph Pecoraro.
+
+ r266669 changed `WI.DOMBreakpoint` to use `WI.DOMNode` instead of `DOM.NodeId`, meaning that
+ `WI.DOMTreeContentView.prototype._updateBreakpointStatus` now expects a `WI.DOMNode`.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WI.DOMTreeContentView.prototype._domTreeElementAdded):
+
2020-10-26 Devin Rousso <[email protected]>
Web Inspector: console command line API should be exposed to breakpoint conditions/actions
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (269070 => 269071)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2020-10-27 21:04:15 UTC (rev 269070)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2020-10-27 21:38:15 UTC (rev 269071)
@@ -500,7 +500,7 @@
if (!this._pendingBreakpointNodes.delete(node))
return;
- this._updateBreakpointStatus(node.id);
+ this._updateBreakpointStatus(node);
}
_domTreeSelectionDidChange(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
