Title: [269072] trunk
- Revision
- 269072
- Author
- [email protected]
- Date
- 2020-10-27 14:40:20 -0700 (Tue, 27 Oct 2020)
Log Message
[TextureMapper][GTK] Test compositing/clipping/border-radius-stacking-context-clip.html is failing
https://bugs.webkit.org/show_bug.cgi?id=214868
Reviewed by Carlos Garcia Campos.
Source/WebCore:
If a replica layer has m_state.pos, m_layerTransforms.combined
should be translated by them.
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::computeTransformsRecursive):
* platform/graphics/texmap/TextureMapperLayer.h:
LayoutTests:
* platform/gtk/TestExpectations: Unmarked compositing/clipping/border-radius-stacking-context-clip.html.
* platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png: Updated.
* platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png: Updated.
* platform/gtk/compositing/reflections/reflection-positioning2-expected.png: Updated.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (269071 => 269072)
--- trunk/LayoutTests/ChangeLog 2020-10-27 21:38:15 UTC (rev 269071)
+++ trunk/LayoutTests/ChangeLog 2020-10-27 21:40:20 UTC (rev 269072)
@@ -1,3 +1,15 @@
+2020-10-27 Fujii Hironori <[email protected]>
+
+ [TextureMapper][GTK] Test compositing/clipping/border-radius-stacking-context-clip.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=214868
+
+ Reviewed by Carlos Garcia Campos.
+
+ * platform/gtk/TestExpectations: Unmarked compositing/clipping/border-radius-stacking-context-clip.html.
+ * platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png: Updated.
+ * platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png: Updated.
+ * platform/gtk/compositing/reflections/reflection-positioning2-expected.png: Updated.
+
2020-10-27 Martin Robinson <[email protected]>
Overflow scrollIntoView wrong with borders
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (269071 => 269072)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2020-10-27 21:38:15 UTC (rev 269071)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2020-10-27 21:40:20 UTC (rev 269072)
@@ -447,7 +447,6 @@
webkit.org/b/169918 compositing/webgl/webgl-reflection.html [ Missing Failure ]
webkit.org/b/169918 compositing/fixed-with-fixed-layout.html [ Crash ]
webkit.org/b/169918 compositing/video/video-background-color.html [ Crash Pass ]
-webkit.org/b/214868 compositing/clipping/border-radius-stacking-context-clip.html [ ImageOnlyFailure ]
# WebGL related failures
webkit.org/b/169917 fast/canvas/webgl/antialiasing-enabled.html [ Failure Pass ]
Modified: trunk/LayoutTests/platform/gtk/compositing/reflections/nested-reflection-transformed-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/gtk/compositing/reflections/nested-reflection-transformed2-expected.png
(Binary files differ)
Modified: trunk/LayoutTests/platform/gtk/compositing/reflections/reflection-positioning2-expected.png
(Binary files differ)
Modified: trunk/Source/WebCore/ChangeLog (269071 => 269072)
--- trunk/Source/WebCore/ChangeLog 2020-10-27 21:38:15 UTC (rev 269071)
+++ trunk/Source/WebCore/ChangeLog 2020-10-27 21:40:20 UTC (rev 269072)
@@ -1,3 +1,17 @@
+2020-10-27 Fujii Hironori <[email protected]>
+
+ [TextureMapper][GTK] Test compositing/clipping/border-radius-stacking-context-clip.html is failing
+ https://bugs.webkit.org/show_bug.cgi?id=214868
+
+ Reviewed by Carlos Garcia Campos.
+
+ If a replica layer has m_state.pos, m_layerTransforms.combined
+ should be translated by them.
+
+ * platform/graphics/texmap/TextureMapperLayer.cpp:
+ (WebCore::TextureMapperLayer::computeTransformsRecursive):
+ * platform/graphics/texmap/TextureMapperLayer.h:
+
2020-10-27 Martin Robinson <[email protected]>
Overflow scrollIntoView wrong with borders
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp (269071 => 269072)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2020-10-27 21:38:15 UTC (rev 269071)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.cpp 2020-10-27 21:40:20 UTC (rev 269072)
@@ -76,6 +76,9 @@
m_layerTransforms.combinedForChildren = m_layerTransforms.combined;
m_layerTransforms.combined.translate3d(-originX, -originY, -m_state.anchorPoint.z());
+ if (m_isReplica)
+ m_layerTransforms.combined.translate(-m_state.pos.x(), -m_state.pos.y());
+
if (!m_state.preserves3D)
m_layerTransforms.combinedForChildren = m_layerTransforms.combinedForChildren.to2dTransform();
m_layerTransforms.combinedForChildren.multiply(m_state.childrenTransform);
@@ -577,6 +580,7 @@
void TextureMapperLayer::setReplicaLayer(TextureMapperLayer* replicaLayer)
{
if (replicaLayer) {
+ replicaLayer->m_isReplica = true;
replicaLayer->m_effectTarget = makeWeakPtr(*this);
m_state.replicaLayer = makeWeakPtr(*replicaLayer);
} else
Modified: trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h (269071 => 269072)
--- trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2020-10-27 21:38:15 UTC (rev 269071)
+++ trunk/Source/WebCore/platform/graphics/texmap/TextureMapperLayer.h 2020-10-27 21:40:20 UTC (rev 269072)
@@ -213,6 +213,7 @@
RefPtr<Nicosia::AnimatedBackingStoreClient> m_animatedBackingStoreClient;
#endif
bool m_isBackdrop { false };
+ bool m_isReplica { false };
struct {
TransformationMatrix localTransform;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
