Title: [269261] trunk/Tools
- Revision
- 269261
- Author
- [email protected]
- Date
- 2020-11-02 11:21:51 -0800 (Mon, 02 Nov 2020)
Log Message
Only upload to S3 when running on ews-build.webkit.org (follow-up fix for unit-test).
https://bugs.webkit.org/show_bug.cgi?id=218439
Unreviewed follow-up fix.
* CISupport/ews-build/steps_unittest.py: Set CURRENT_HOSTNAME to EWS_BUILD_HOSTNAME during TestTransferToS3 unit-tests,
restore it in tearDown so that it doesn't affect any other unit-test.
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps_unittest.py (269260 => 269261)
--- trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-11-02 19:20:27 UTC (rev 269260)
+++ trunk/Tools/CISupport/ews-build/steps_unittest.py 2020-11-02 19:21:51 UTC (rev 269261)
@@ -2662,9 +2662,14 @@
class TestTransferToS3(BuildStepMixinAdditions, unittest.TestCase):
def setUp(self):
self.longMessage = True
+ import steps
+ self.current_hostname = steps.CURRENT_HOSTNAME
+ steps.CURRENT_HOSTNAME = steps.EWS_BUILD_HOSTNAME
return self.setUpBuildStep()
def tearDown(self):
+ import steps
+ steps.CURRENT_HOSTNAME = self.current_hostname
return self.tearDownBuildStep()
def test_success(self):
Modified: trunk/Tools/ChangeLog (269260 => 269261)
--- trunk/Tools/ChangeLog 2020-11-02 19:20:27 UTC (rev 269260)
+++ trunk/Tools/ChangeLog 2020-11-02 19:21:51 UTC (rev 269261)
@@ -1,3 +1,13 @@
+2020-11-02 Aakash Jain <[email protected]>
+
+ Only upload to S3 when running on ews-build.webkit.org (follow-up fix for unit-test).
+ https://bugs.webkit.org/show_bug.cgi?id=218439
+
+ Unreviewed follow-up fix.
+
+ * CISupport/ews-build/steps_unittest.py: Set CURRENT_HOSTNAME to EWS_BUILD_HOSTNAME during TestTransferToS3 unit-tests,
+ restore it in tearDown so that it doesn't affect any other unit-test.
+
2020-11-01 Darin Adler <[email protected]>
Start removing functions that implicitly use composed tree
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
