Title: [269262] trunk/LayoutTests
Revision
269262
Author
[email protected]
Date
2020-11-02 11:45:00 -0800 (Mon, 02 Nov 2020)

Log Message

[LFC] Do not [ ImageOnlyFailure ] all the tests in fast/layoutformattingcontext
https://bugs.webkit.org/show_bug.cgi?id=218446

Many tests pass now.

Reviewed by Simon Fraser.

* TestExpectations:
* platform/mac-wk2/TestExpectations:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (269261 => 269262)


--- trunk/LayoutTests/ChangeLog	2020-11-02 19:21:51 UTC (rev 269261)
+++ trunk/LayoutTests/ChangeLog	2020-11-02 19:45:00 UTC (rev 269262)
@@ -1,3 +1,15 @@
+2020-11-02  Zalan Bujtas  <[email protected]>
+
+        [LFC] Do not [ ImageOnlyFailure ] all the tests in fast/layoutformattingcontext
+        https://bugs.webkit.org/show_bug.cgi?id=218446
+
+        Many tests pass now.
+
+        Reviewed by Simon Fraser.
+
+        * TestExpectations:
+        * platform/mac-wk2/TestExpectations:
+
 2020-11-02  Chris Dumez  <[email protected]>
 
         REGRESSION (r268897): [macOS WK1] inspector/cpu-profiler/threads.html is a flaky failure

Modified: trunk/LayoutTests/TestExpectations (269261 => 269262)


--- trunk/LayoutTests/TestExpectations	2020-11-02 19:21:51 UTC (rev 269261)
+++ trunk/LayoutTests/TestExpectations	2020-11-02 19:45:00 UTC (rev 269262)
@@ -4557,7 +4557,73 @@
 # These tests rely on webkit-test-runner flags that aren't implemented for DumpRenderTree, so they will fail under legacy WebKit.
 editing/selection/expando.html [ Failure ]
 
-fast/layoutformattingcontext/ [ ImageOnlyFailure ]
+# These tests fail because of missing painting features in LFC (they still pass the layout ASSERT test).
+# webkit.org/b/216471
+fast/layoutformattingcontext/absolute-positioned-box-with-inline-sibling.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/absolute-positioned-simple-table.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/absolute-positioned-simple-table2.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/absolute-positioned-simple-table3.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/br-and-wbr-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/float-avoiding-br-last-line.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/float-avoiding-br-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/float-in-inline-context-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/float-inside-table-cell-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/float-with-clear-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/floats-shrinking-line-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/flow-integration-basic.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/html-is-absolute-positioned.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/inlin-box-content-fits-but-the-box-does-not.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/inline-box-overlaps-multiple-lines.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/inline-text-outside-of-inline-container-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/intrusive-floats-takes-entire-horizontal-space.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/line-heigt-when-text-is-inside-inline-container.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/min-max-content-width-simple2.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/out-of-flow-html-and-body-stretches-to-viewport.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/quirk-margin-not-collapse-when-floating.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/run-expansion-extends-line-content-width.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/simple-absolute-positioned-inline-element.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/simple-absolute-positioned-replaced-inline-element-with-percentage-height.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/simple-inline-block.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/simple-table-with-empty-td.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/subframe-with-display-none-html.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-basic-row-baseline-align.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-basic-row-baseline-with-nested-table.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-basic-row-vertical-align-baseline.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-cell-baseline-offset-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-cell-baseline-offset-simple2.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-cell-vertical-alignment-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-colspan-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-fixed-row-height-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-fixed-width-colspans.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-fixed-width-with-max-distribution.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-flex-width-border-collapse.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-flex-width-colspans.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-min-max-width-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-missing-cells-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-border-collapse-with-padding.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-border-collapse3.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-collapsed-row-border.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-collapsed-row-border2.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-fixed-width-with-wide-content.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-multiple-sections.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-row-border.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-rowspan-with-spacing.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-tall-cell-content-with-fixed-height.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-thead-border-ignore.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-with-border.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-with-fixed-widht-and-inline-content.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-simple-with-padding.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/table-with-column-spanner-first-row.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/wbr-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/abs-pos-with-border-padding-and-float-child.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/absolute-position-left-right-margin.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/absolute-position-with-margin-auto-simple2.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/min-max-and-preferred-width-simple.html [ ImageOnlyFailure ]
+fast/layoutformattingcontext/block-only/out-of-flow-is-never-float-box.html [ ImageOnlyFailure ]
 webkit.org/b/217054 fast/layoutformattingcontext/horizontal-sizing-with-trailing-letter-spacing.html [ Skip ]
 
 # These tests are for iOS port.

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (269261 => 269262)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-11-02 19:21:51 UTC (rev 269261)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2020-11-02 19:45:00 UTC (rev 269262)
@@ -1193,24 +1193,6 @@
 [ arm64 ] fast/replaced/no-focus-ring-embed.html [ Skip ]
 [ arm64 ] fast/replaced/no-focus-ring-object.html [ Skip ]
 
-# LFC painting is work in progress
-webkit.org/b/216471 fast/layoutformattingcontext/block-only/replaced-intrinsic-width-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/empty-table-with-specified-height-quirk-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/empty-table-with-specified-height-standards-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/float-in-inline-context-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/floats-shrinking-line-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/subframe-with-display-none-html.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-cell-vertical-alignment-simple.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-border-collapse-with-padding.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-border-collapse3.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-collapsed-row-border.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-collapsed-row-border2.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-collapsed-tbody-border.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-multiple-sections.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-row-border.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-rowspan-with-spacing.html [ ImageOnlyFailure ]
-webkit.org/b/216471 fast/layoutformattingcontext/table-simple-thead-border-ignore.html [ ImageOnlyFailure ]
-
 # rdar://66703773 (REGRESSION (20A2316-20A2348b): http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window.html is a constant failure)
 [ arm64 ] http/tests/security/contentSecurityPolicy/plugin-blocked-in-about-blank-window.html [ Skip ]
 
@@ -1306,3 +1288,7 @@
 webkit.org/b/217938 [ Mojave+ ] http/wpt/service-workers/online.https.html [ Pass Failure ]
 
 webkit.org/b/218341 inspector/dom-debugger/attribute-modified-style.html [ Pass Timeout ]
+
+# These tests fail because of missing painting features in LFC (they still pass the layout ASSERT test).
+# webkit.org/b/216471
+[ Mojave ] fast/layoutformattingcontext/table-with-margin-content-simple.html [ ImageOnlyFailure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to