Title: [269319] branches/safari-610-branch/Source/WebCore
Revision
269319
Author
[email protected]
Date
2020-11-03 11:14:17 -0800 (Tue, 03 Nov 2020)

Log Message

Cherry-pick r269190. rdar://problem/70970247

    Increase camera failing timer to 30 seconds
    https://bugs.webkit.org/show_bug.cgi?id=218389

    Reviewed by Eric Carlson.

    From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
    Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.

    * platform/mediastream/mac/AVVideoCaptureSource.h:

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-610-branch/Source/WebCore/ChangeLog (269318 => 269319)


--- branches/safari-610-branch/Source/WebCore/ChangeLog	2020-11-03 19:14:14 UTC (rev 269318)
+++ branches/safari-610-branch/Source/WebCore/ChangeLog	2020-11-03 19:14:17 UTC (rev 269319)
@@ -1,5 +1,34 @@
 2020-11-02  Alan Coon  <[email protected]>
 
+        Cherry-pick r269190. rdar://problem/70970247
+
+    Increase camera failing timer to 30 seconds
+    https://bugs.webkit.org/show_bug.cgi?id=218389
+    
+    Reviewed by Eric Carlson.
+    
+    From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
+    Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.
+    
+    * platform/mediastream/mac/AVVideoCaptureSource.h:
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@269190 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-10-30  Youenn Fablet  <[email protected]>
+
+            Increase camera failing timer to 30 seconds
+            https://bugs.webkit.org/show_bug.cgi?id=218389
+
+            Reviewed by Eric Carlson.
+
+            From testing, 3 seconds is not always enough if getUserMedia is quickly called multiple times.
+            Let's increase to 30 seconds to give room for slow systems while still being able to identify failures.
+
+            * platform/mediastream/mac/AVVideoCaptureSource.h:
+
+2020-11-02  Alan Coon  <[email protected]>
+
         Cherry-pick r266364. rdar://problem/70970205
 
     Implement WEBGL_compressed_texture_s3tc_srgb extension

Modified: branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h (269318 => 269319)


--- branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h	2020-11-03 19:14:14 UTC (rev 269318)
+++ branches/safari-610-branch/Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.h	2020-11-03 19:14:17 UTC (rev 269319)
@@ -139,7 +139,7 @@
     bool m_interrupted { false };
     bool m_isRunning { false };
 
-    static constexpr Seconds verifyCaptureInterval = 3_s;
+    static constexpr Seconds verifyCaptureInterval = 30_s;
     static const uint64_t framesToDropWhenStarting = 4;
 
     Timer m_verifyCapturingTimer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to