Title: [269335] trunk/Tools
Revision
269335
Author
[email protected]
Date
2020-11-03 15:05:29 -0800 (Tue, 03 Nov 2020)

Log Message

[webkitscmpy] Populate parent branch for tags
<rdar://problem/70998928>
https://bugs.webkit.org/show_bug.cgi?id=218521

Rubber-stamped by Aakash Jain.

* Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Version bump.
* Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
(Svn.commit): Populate cache of commits when the canonical branch does not match
the provided commit.
* Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
(TestSvn):
(TestSvn.test_tag_previous):

Modified Paths

Diff

Modified: trunk/Tools/ChangeLog (269334 => 269335)


--- trunk/Tools/ChangeLog	2020-11-03 22:49:24 UTC (rev 269334)
+++ trunk/Tools/ChangeLog	2020-11-03 23:05:29 UTC (rev 269335)
@@ -1,3 +1,19 @@
+2020-11-03  Jonathan Bedard  <[email protected]>
+
+        [webkitscmpy] Populate parent branch for tags
+        <rdar://problem/70998928>
+        https://bugs.webkit.org/show_bug.cgi?id=218521
+
+        Rubber-stamped by Aakash Jain.
+
+        * Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Version bump.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:
+        (Svn.commit): Populate cache of commits when the canonical branch does not match
+        the provided commit.
+        * Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py:
+        (TestSvn):
+        (TestSvn.test_tag_previous):
+
 2020-11-03  David Kilzer  <[email protected]>
 
         Add test for cacheModelForMainBundle() in WebKitLegacy

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py (269334 => 269335)


--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2020-11-03 22:49:24 UTC (rev 269334)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py	2020-11-03 23:05:29 UTC (rev 269335)
@@ -46,7 +46,7 @@
         "Please install webkitcorepy with `pip install webkitcorepy --extra-index-url <package index URL>`"
     )
 
-version = Version(0, 2, 6)
+version = Version(0, 2, 7)
 
 AutoInstall.register(Package('dateutil', Version(2, 8, 1), pypi_name='python-dateutil'))
 

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py (269334 => 269335)


--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2020-11-03 22:49:24 UTC (rev 269334)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py	2020-11-03 23:05:29 UTC (rev 269335)
@@ -300,6 +300,8 @@
             revision = self._metadata_cache[branch][identifier]
             info = self.info(cached=True, branch=branch, revision=revision)
             branch = self._branch_for(revision)
+            if not self._metadata_cache.get(branch, []) or identifier >= len(self._metadata_cache.get(branch, [])):
+                self._cache_revisions(branch=branch)
 
         elif revision:
             if branch:

Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py (269334 => 269335)


--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py	2020-11-03 22:49:24 UTC (rev 269334)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/svn_unittest.py	2020-11-03 23:05:29 UTC (rev 269335)
@@ -200,3 +200,7 @@
     def test_tag(self):
         with mocks.local.Svn(self.path), OutputCapture():
             self.assertEqual(9, local.Svn(self.path).commit(tag='tag-1').revision)
+
+    def test_tag_previous(self):
+        with mocks.local.Svn(self.path), OutputCapture():
+            self.assertEqual(7, local.Svn(self.path).commit(identifier='2.2@tags/tag-1').revision)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to