Title: [269338] trunk/Source/_javascript_Core
- Revision
- 269338
- Author
- [email protected]
- Date
- 2020-11-03 15:36:18 -0800 (Tue, 03 Nov 2020)
Log Message
Don't assert there is no checkpoint side state when dropping the JSLock
https://bugs.webkit.org/show_bug.cgi?id=218537
Reviewed by Filip Pizlo.
You may have multiple OSR exit sidestate data on the stack, and then call into
API code, which might DropAllLocks. Hence, this assert is wrong.
Working on a test. Will land in a followup.
* runtime/JSLock.cpp:
(JSC::JSLock::willReleaseLock):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (269337 => 269338)
--- trunk/Source/_javascript_Core/ChangeLog 2020-11-03 23:33:31 UTC (rev 269337)
+++ trunk/Source/_javascript_Core/ChangeLog 2020-11-03 23:36:18 UTC (rev 269338)
@@ -1,3 +1,18 @@
+2020-11-03 Saam Barati <[email protected]>
+
+ Don't assert there is no checkpoint side state when dropping the JSLock
+ https://bugs.webkit.org/show_bug.cgi?id=218537
+
+ Reviewed by Filip Pizlo.
+
+ You may have multiple OSR exit sidestate data on the stack, and then call into
+ API code, which might DropAllLocks. Hence, this assert is wrong.
+
+ Working on a test. Will land in a followup.
+
+ * runtime/JSLock.cpp:
+ (JSC::JSLock::willReleaseLock):
+
2020-11-03 Yusuke Suzuki <[email protected]>
REGRESSION (r254038): Simple.com money transfer UI is very laggy (multiple seconds per keypress)
Modified: trunk/Source/_javascript_Core/runtime/JSLock.cpp (269337 => 269338)
--- trunk/Source/_javascript_Core/runtime/JSLock.cpp 2020-11-03 23:33:31 UTC (rev 269337)
+++ trunk/Source/_javascript_Core/runtime/JSLock.cpp 2020-11-03 23:36:18 UTC (rev 269338)
@@ -200,7 +200,6 @@
{
RefPtr<VM> vm = m_vm;
if (vm) {
- RELEASE_ASSERT_WITH_MESSAGE(!vm->hasCheckpointOSRSideState(), "Releasing JSLock but pending checkpoint side state still available");
vm->drainMicrotasks();
if (!vm->topCallFrame)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
