Title: [269625] trunk/Tools
- Revision
- 269625
- Author
- [email protected]
- Date
- 2020-11-10 05:30:30 -0800 (Tue, 10 Nov 2020)
Log Message
[GTK] [REGRESSSION(r269390) Several editing/ tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=218607
Reviewed by Adrian Perez de Castro.
After r269390 some of the internal preferences like LiveRangeSelectionEnabled
are not resetted to their default value on WTR between test runs.
So when a test changes some of this properties it may cause failures on
the next tests that will run on the same WTR process.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues): Add back the call to WKPreferencesResetAllInternalDebugFeatures() that was removed on r269390.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (269624 => 269625)
--- trunk/Tools/ChangeLog 2020-11-10 11:44:33 UTC (rev 269624)
+++ trunk/Tools/ChangeLog 2020-11-10 13:30:30 UTC (rev 269625)
@@ -1,3 +1,18 @@
+2020-11-10 Carlos Alberto Lopez Perez <[email protected]>
+
+ [GTK] [REGRESSSION(r269390) Several editing/ tests are flaky
+ https://bugs.webkit.org/show_bug.cgi?id=218607
+
+ Reviewed by Adrian Perez de Castro.
+
+ After r269390 some of the internal preferences like LiveRangeSelectionEnabled
+ are not resetted to their default value on WTR between test runs.
+ So when a test changes some of this properties it may cause failures on
+ the next tests that will run on the same WTR process.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues): Add back the call to WKPreferencesResetAllInternalDebugFeatures() that was removed on r269390.
+
2020-11-10 Carlos Garcia Campos <[email protected]>
[GTK] MiniBrowser: add buttons to insert ordered/unordered lists to editor toolbar
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (269624 => 269625)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2020-11-10 11:44:33 UTC (rev 269624)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2020-11-10 13:30:30 UTC (rev 269625)
@@ -829,6 +829,7 @@
WKPreferencesResetTestRunnerOverrides(preferences);
WKPreferencesEnableAllExperimentalFeatures(preferences);
+ WKPreferencesResetAllInternalDebugFeatures(preferences);
// FIXME: Convert these to default values for TestOptions.
WKPreferencesSetProcessSwapOnNavigationEnabled(preferences, options.shouldEnableProcessSwapOnNavigation());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
