Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (269623 => 269624)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2020-11-10 11:44:33 UTC (rev 269624)
@@ -1,5 +1,16 @@
2020-11-10 Antoine Quint <[email protected]>
+ align-self should be a discrete animatable property
+ https://bugs.webkit.org/show_bug.cgi?id=218742
+
+ Reviewed by Antti Koivisto.
+
+ * web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt:
+ * web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt:
+
+2020-11-10 Antoine Quint <[email protected]>
+
[Web Animations] KeyframeEffect.pseudoElement does not return a valid string when targeting ::marker or ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=218741
<rdar://problem/71229846>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt (269623 => 269624)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/accumulation-per-property-001-expected.txt 2020-11-10 11:44:33 UTC (rev 269624)
@@ -6,6 +6,9 @@
PASS align-items (type: discrete) has testAccumulation function
PASS align-items: "flex-end" onto "flex-start"
PASS align-items: "flex-start" onto "flex-end"
+PASS align-self (type: discrete) has testAccumulation function
+PASS align-self: "flex-end" onto "flex-start"
+PASS align-self: "flex-start" onto "flex-end"
PASS background-color (type: color) has testAccumulation function
FAIL background-color supports animating as color of rgb() with overflowed from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
FAIL background-color supports animating as color of #RGB assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt (269623 => 269624)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-001-expected.txt 2020-11-10 11:44:33 UTC (rev 269624)
@@ -6,6 +6,9 @@
PASS align-items (type: discrete) has testAddition function
PASS align-items: "flex-end" onto "flex-start"
PASS align-items: "flex-start" onto "flex-end"
+PASS align-self (type: discrete) has testAddition function
+PASS align-self: "flex-end" onto "flex-start"
+PASS align-self: "flex-start" onto "flex-end"
PASS background-color (type: color) has testAddition function
FAIL background-color supports animating as color of rgb() with overflowed from and to values assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
FAIL background-color supports animating as color of #RGB assert_equals: The value should be rgb(255, 128, 128) at 0ms expected "rgb(255, 128, 128)" but got "rgb(255, 0, 0)"
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt (269623 => 269624)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-001-expected.txt 2020-11-10 11:44:33 UTC (rev 269624)
@@ -8,6 +8,10 @@
PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with linear easing
PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with effect easing
PASS align-items uses discrete animation when animating between "flex-start" and "flex-end" with keyframe easing
+PASS align-self (type: discrete) has testInterpolation function
+PASS align-self uses discrete animation when animating between "flex-start" and "flex-end" with linear easing
+PASS align-self uses discrete animation when animating between "flex-start" and "flex-end" with effect easing
+PASS align-self uses discrete animation when animating between "flex-start" and "flex-end" with keyframe easing
PASS background-color (type: color) has testInterpolation function
PASS background-color supports animating as color of rgb()
PASS background-color supports animating as color of #RGB
Modified: trunk/Source/WebCore/ChangeLog (269623 => 269624)
--- trunk/Source/WebCore/ChangeLog 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/Source/WebCore/ChangeLog 2020-11-10 11:44:33 UTC (rev 269624)
@@ -1,5 +1,15 @@
2020-11-10 Antoine Quint <[email protected]>
+ align-self should be a discrete animatable property
+ https://bugs.webkit.org/show_bug.cgi?id=218742
+
+ Reviewed by Antti Koivisto.
+
+ * animation/CSSPropertyAnimation.cpp:
+ (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
+
+2020-11-10 Antoine Quint <[email protected]>
+
[Web Animations] KeyframeEffect.pseudoElement does not return a valid string when targeting ::marker or ::first-letter
https://bugs.webkit.org/show_bug.cgi?id=218741
<rdar://problem/71229846>
Modified: trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp (269623 => 269624)
--- trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2020-11-10 11:35:51 UTC (rev 269623)
+++ trunk/Source/WebCore/animation/CSSPropertyAnimation.cpp 2020-11-10 11:44:33 UTC (rev 269624)
@@ -1902,6 +1902,7 @@
new DiscretePropertyWrapper<const StyleContentAlignmentData&>(CSSPropertyAlignContent, &RenderStyle::alignContent, &RenderStyle::setAlignContent),
new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignItems, &RenderStyle::alignItems, &RenderStyle::setAlignItems),
+ new DiscretePropertyWrapper<const StyleSelfAlignmentData&>(CSSPropertyAlignSelf, &RenderStyle::alignSelf, &RenderStyle::setAlignSelf),
};
const unsigned animatableLonghandPropertiesCount = WTF_ARRAY_LENGTH(animatableLonghandPropertyWrappers);
