Title: [269754] trunk/Source/WebInspectorUI
Revision
269754
Author
[email protected]
Date
2020-11-12 14:44:45 -0800 (Thu, 12 Nov 2020)

Log Message

Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
https://bugs.webkit.org/show_bug.cgi?id=218679

Reviewed by Brian Burg.

* UserInterface/Views/SourcesNavigationSidebarPanel.js:
(WI.SourcesNavigationSidebarPanel.prototype._addResource):
Make sure to use `WI.WebSocketResourceTreeElement` for `WI.WebSocketResource`.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (269753 => 269754)


--- trunk/Source/WebInspectorUI/ChangeLog	2020-11-12 22:31:04 UTC (rev 269753)
+++ trunk/Source/WebInspectorUI/ChangeLog	2020-11-12 22:44:45 UTC (rev 269754)
@@ -1,3 +1,14 @@
+2020-11-12  Devin Rousso  <[email protected]>
+
+        Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
+        https://bugs.webkit.org/show_bug.cgi?id=218679
+
+        Reviewed by Brian Burg.
+
+        * UserInterface/Views/SourcesNavigationSidebarPanel.js:
+        (WI.SourcesNavigationSidebarPanel.prototype._addResource):
+        Make sure to use `WI.WebSocketResourceTreeElement` for `WI.WebSocketResource`.
+
 2020-11-11  John Wilander  <[email protected]>
 
         PCM: Change from ad-click-attribution to private-click-measurement (in all forms, including .well-known URL)

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js (269753 => 269754)


--- trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js	2020-11-12 22:31:04 UTC (rev 269753)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SourcesNavigationSidebarPanel.js	2020-11-12 22:44:45 UTC (rev 269754)
@@ -1080,8 +1080,10 @@
             let resourceTreeElement = null;
             if (resource instanceof WI.CSSStyleSheet)
                 resourceTreeElement = new WI.CSSStyleSheetTreeElement(resource);
-            else
-                resourceTreeElement = new WI.ResourceTreeElement(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            else {
+                let constructor = resource.type === WI.Resource.Type.WebSocket ? WI.WebSocketResourceTreeElement : WI.ResourceTreeElement;
+                resourceTreeElement = new constructor(resource, resource, {allowDirectoryAsName: true, hideOrigin: true});
+            }
 
             let index = insertionIndexForObjectInListSortedByFunction(resourceTreeElement, parentTreeElement.children, this._boundCompareTreeElements);
             parentTreeElement.insertChild(resourceTreeElement, index);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to