Title: [269755] trunk/Source/WebInspectorUI
- Revision
- 269755
- Author
- [email protected]
- Date
- 2020-11-12 14:49:39 -0800 (Thu, 12 Nov 2020)
Log Message
Web Inspector: REGRESSION(?): Graphics: cannot click on recording icon more than once
https://bugs.webkit.org/show_bug.cgi?id=218834
Reviewed by Brian Burg.
* UserInterface/Views/ContextMenuUtilities.js:
(WI.addMouseDownContextMenuHandlers):
Only ignore future `"mousedown"` events if the `WI.ContextMenu` actually has items.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (269754 => 269755)
--- trunk/Source/WebInspectorUI/ChangeLog 2020-11-12 22:44:45 UTC (rev 269754)
+++ trunk/Source/WebInspectorUI/ChangeLog 2020-11-12 22:49:39 UTC (rev 269755)
@@ -1,5 +1,16 @@
2020-11-12 Devin Rousso <[email protected]>
+ Web Inspector: REGRESSION(?): Graphics: cannot click on recording icon more than once
+ https://bugs.webkit.org/show_bug.cgi?id=218834
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Views/ContextMenuUtilities.js:
+ (WI.addMouseDownContextMenuHandlers):
+ Only ignore future `"mousedown"` events if the `WI.ContextMenu` actually has items.
+
+2020-11-12 Devin Rousso <[email protected]>
+
Web Inspector: REGRESSION(?): Sources: WebSocket status not shown when organized By Path
https://bugs.webkit.org/show_bug.cgi?id=218679
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js (269754 => 269755)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2020-11-12 22:44:45 UTC (rev 269754)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js 2020-11-12 22:49:39 UTC (rev 269755)
@@ -35,8 +35,6 @@
if (ignoreMouseDown)
return;
- ignoreMouseDown = true;
-
let contextMenu = WI.ContextMenu.createFromEvent(event);
contextMenu.addBeforeShowCallback(() => {
ignoreMouseDown = false;
@@ -44,6 +42,7 @@
populateContextMenuCallback(contextMenu, event);
+ ignoreMouseDown = !contextMenu.isEmpty();
contextMenu.show();
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
