Title: [271448] trunk/Source/WebKit
Revision
271448
Author
[email protected]
Date
2021-01-13 11:42:29 -0800 (Wed, 13 Jan 2021)

Log Message

PCM: Experimental debug mode needs to be read from defaults differently on iOS
https://bugs.webkit.org/show_bug.cgi?id=220573
<rdar://problem/73092137>

Reviewed by Brent Fulgham.

Experimental features on iOS use the prefix "WebKitExperimental" so we
need to read it that way on that platform. PCM is not supported on other
platforms than macOS and iOS at this point.

* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (271447 => 271448)


--- trunk/Source/WebKit/ChangeLog	2021-01-13 19:25:37 UTC (rev 271447)
+++ trunk/Source/WebKit/ChangeLog	2021-01-13 19:42:29 UTC (rev 271448)
@@ -1,3 +1,18 @@
+2021-01-13  John Wilander  <[email protected]>
+
+        PCM: Experimental debug mode needs to be read from defaults differently on iOS
+        https://bugs.webkit.org/show_bug.cgi?id=220573
+        <rdar://problem/73092137>
+
+        Reviewed by Brent Fulgham.
+
+        Experimental features on iOS use the prefix "WebKitExperimental" so we
+        need to read it that way on that platform. PCM is not supported on other
+        platforms than macOS and iOS at this point.
+
+        * UIProcess/Cocoa/WebProcessPoolCocoa.mm:
+        (WebKit::WebProcessPool::platformInitializeNetworkProcess):
+
 2021-01-13  Megan Gardner  <[email protected]>
 
         Defer setting up app highlight menus until needed to not delay launch time.

Modified: trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm (271447 => 271448)


--- trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-01-13 19:25:37 UTC (rev 271447)
+++ trunk/Source/WebKit/UIProcess/Cocoa/WebProcessPoolCocoa.mm	2021-01-13 19:42:29 UTC (rev 271448)
@@ -491,7 +491,12 @@
 #endif
 
     parameters.enablePrivateClickMeasurement = ![defaults objectForKey:WebPreferencesKey::privateClickMeasurementEnabledKey()] || [defaults boolForKey:WebPreferencesKey::privateClickMeasurementEnabledKey()];
-    parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:@"Experimental%@", WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]];
+#if PLATFORM(MAC)
+    NSString *format = @"Experimental%@";
+#else
+    NSString *format = @"WebKitExperimental%@";
+#endif
+    parameters.enablePrivateClickMeasurementDebugMode = [defaults boolForKey:[NSString stringWithFormat:format, WebPreferencesKey::privateClickMeasurementDebugModeEnabledKey().createCFString().get()]];
 }
 
 void WebProcessPool::platformInvalidateContext()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to