Title: [271449] trunk/Source/_javascript_Core
Revision
271449
Author
[email protected]
Date
2021-01-13 12:16:23 -0800 (Wed, 13 Jan 2021)

Log Message

[JSC] Remove the unused compilation byproducts from the wasm embedder entrypoint
https://bugs.webkit.org/show_bug.cgi?id=220587

Patch by Xan Lopez <[email protected]> on 2021-01-13
Reviewed by Yusuke Suzuki.

This is just passed around uninitialized, remove it.

* wasm/WasmB3IRGenerator.h:
* wasm/WasmBBQPlan.cpp:
(JSC::Wasm::BBQPlan::didCompleteCompilation):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (271448 => 271449)


--- trunk/Source/_javascript_Core/ChangeLog	2021-01-13 19:42:29 UTC (rev 271448)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-01-13 20:16:23 UTC (rev 271449)
@@ -1,3 +1,16 @@
+2021-01-13  Xan Lopez  <[email protected]>
+
+        [JSC] Remove the unused compilation byproducts from the wasm embedder entrypoint
+        https://bugs.webkit.org/show_bug.cgi?id=220587
+
+        Reviewed by Yusuke Suzuki.
+
+        This is just passed around uninitialized, remove it.
+
+        * wasm/WasmB3IRGenerator.h:
+        * wasm/WasmBBQPlan.cpp:
+        (JSC::Wasm::BBQPlan::didCompleteCompilation):
+
 2021-01-12  Ross Kirsling  <[email protected]>
 
         [JSC] Class name 'await' is valid in sync context

Modified: trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.h (271448 => 271449)


--- trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.h	2021-01-13 19:42:29 UTC (rev 271448)
+++ trunk/Source/_javascript_Core/wasm/WasmB3IRGenerator.h	2021-01-13 20:16:23 UTC (rev 271449)
@@ -46,7 +46,6 @@
 
 struct CompilationContext {
     std::unique_ptr<CCallHelpers> embedderEntrypointJIT;
-    std::unique_ptr<B3::OpaqueByproducts> embedderEntrypointByproducts;
     std::unique_ptr<CCallHelpers> wasmEntrypointJIT;
     std::unique_ptr<B3::OpaqueByproducts> wasmEntrypointByproducts;
 };

Modified: trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp (271448 => 271449)


--- trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2021-01-13 19:42:29 UTC (rev 271448)
+++ trunk/Source/_javascript_Core/wasm/WasmBBQPlan.cpp	2021-01-13 20:16:23 UTC (rev 271449)
@@ -240,7 +240,7 @@
 
             embedderToWasmInternalFunction->entrypoint.compilation = makeUnique<B3::Compilation>(
                 FINALIZE_CODE(linkBuffer, B3CompilationPtrTag, "Embedder->WebAssembly entrypoint[%i] %s name %s", functionIndex, signature.toString().ascii().data(), makeString(IndexOrName(functionIndexSpace, m_moduleInformation->nameSection->get(functionIndexSpace))).ascii().data()),
-                WTFMove(context.embedderEntrypointByproducts));
+                nullptr);
         }
     }
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to