Title: [271926] trunk/Source
- Revision
- 271926
- Author
- [email protected]
- Date
- 2021-01-26 17:11:19 -0800 (Tue, 26 Jan 2021)
Log Message
REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
https://bugs.webkit.org/show_bug.cgi?id=220996
<rdar://72173139>
Reviewed by Sam Weinig.
Source/WebKitLegacy/mac:
Read back this preference when propagating it, because the value depends on
more than just the preference key. For example, it allows Debug builds to act
as if the preference is always enabled.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WTF:
This preference should use custom bindings for WebKitLegacy.
* Scripts/Preferences/WebPreferencesDebug.yaml:
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (271925 => 271926)
--- trunk/Source/WTF/ChangeLog 2021-01-27 01:06:10 UTC (rev 271925)
+++ trunk/Source/WTF/ChangeLog 2021-01-27 01:11:19 UTC (rev 271926)
@@ -1,3 +1,15 @@
+2021-01-26 BJ Burg <[email protected]>
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ This preference should use custom bindings for WebKitLegacy.
+
+ * Scripts/Preferences/WebPreferencesDebug.yaml:
+
2021-01-26 Saam Barati <[email protected]>
Revive the build when MALLOC_HEAP_BREAKDOWN is enabled
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml (271925 => 271926)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml 2021-01-27 01:06:10 UTC (rev 271925)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml 2021-01-27 01:11:19 UTC (rev 271926)
@@ -65,6 +65,7 @@
DeveloperExtrasEnabled:
type: bool
webKitLegacyPreferenceKey: WebKitDeveloperExtrasEnabledPreferenceKey
+ webKitLegacyBinding: custom
defaultValue:
WebKitLegacy:
default: false
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (271925 => 271926)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-01-27 01:06:10 UTC (rev 271925)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-01-27 01:11:19 UTC (rev 271926)
@@ -1,3 +1,18 @@
+2021-01-26 BJ Burg <[email protected]>
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ Read back this preference when propagating it, because the value depends on
+ more than just the preference key. For example, it allows Debug builds to act
+ as if the preference is always enabled.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2021-01-22 Nikolas Zimmermann <[email protected]>
Finish introduction of RenderLayerScrollableArea: remove remaining glue code from RenderLayer
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebView.mm (271925 => 271926)
--- trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-01-27 01:06:10 UTC (rev 271925)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-01-27 01:11:19 UTC (rev 271926)
@@ -2929,6 +2929,9 @@
settings.setBackForwardCacheExpirationInterval(Seconds { [preferences _backForwardCacheExpirationInterval] });
settings.setPitchCorrectionAlgorithm(static_cast<WebCore::MediaPlayerEnums::PitchCorrectionAlgorithm>([preferences _pitchCorrectionAlgorithm]));
+ // FIXME: Add a way to have a preference check multiple different keys.
+ settings.setDeveloperExtrasEnabled([preferences developerExtrasEnabled]);
+
BOOL mediaPlaybackRequiresUserGesture = [preferences mediaPlaybackRequiresUserGesture];
settings.setVideoPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences videoPlaybackRequiresUserGesture]);
settings.setAudioPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences audioPlaybackRequiresUserGesture]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
