Title: [271927] trunk/Source/WebInspectorUI
- Revision
- 271927
- Author
- [email protected]
- Date
- 2021-01-26 17:12:03 -0800 (Tue, 26 Jan 2021)
Log Message
REGRESSION(r270637) Filtering does not work in Styles sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=220993
<rdar://problem/73623818>
Patch by Razvan Caliman <[email protected]> on 2021-01-26
Reviewed by Devin Rousso.
Stop expecting StyleDetailsPanel to define an abstract filterDidChange() method.
Subclasses implement their own on a per-use case basis.
* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.filterDidChange):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (271926 => 271927)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-01-27 01:11:19 UTC (rev 271926)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-01-27 01:12:03 UTC (rev 271927)
@@ -1,3 +1,19 @@
+2021-01-26 Razvan Caliman <[email protected]>
+
+ REGRESSION(r270637) Filtering does not work in Styles sidebar panel
+ https://bugs.webkit.org/show_bug.cgi?id=220993
+ <rdar://problem/73623818>
+
+ Reviewed by Devin Rousso.
+
+ Stop expecting StyleDetailsPanel to define an abstract filterDidChange() method.
+ Subclasses implement their own on a per-use case basis.
+
+ * UserInterface/Views/ComputedStyleDetailsPanel.js:
+ (WI.ComputedStyleDetailsPanel.prototype.filterDidChange):
+ * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+ (WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
+
2021-01-25 Nikita Vasilyev <[email protected]>
Web Inspector: Add experimental setting to show Layout panel in Elements tab
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (271926 => 271927)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2021-01-27 01:11:19 UTC (rev 271926)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2021-01-27 01:12:03 UTC (rev 271927)
@@ -149,8 +149,6 @@
filterDidChange(filterBar)
{
- super.filterDidChange(filterBar);
-
this.applyFilter(filterBar.filters.text);
}
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js (271926 => 271927)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-01-27 01:11:19 UTC (rev 271926)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-01-27 01:12:03 UTC (rev 271927)
@@ -320,8 +320,6 @@
filterDidChange(filterBar)
{
- super.filterDidChange(filterBar);
-
this.applyFilter(filterBar.filters.text);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
