[webkit-changes] [272265] branches/safari-611-branch/LayoutTests

Tue, 02 Feb 2021 17:41:07 -0800

Title: [272265] branches/safari-611-branch/LayoutTests
Revision
272265
Author
[email protected]
Date
2021-02-02 17:40:24 -0800 (Tue, 02 Feb 2021)

Log Message

Cherry-pick r272030. rdar://problem/73890478

    REGRESSION(r271119) Check for nullness of preamble.caller
    https://bugs.webkit.org/show_bug.cgi?id=220610

    Reviewed by Yusuke Suzuki.

    r271119 changed some kinds of functions to return null when trying to
    access its caller property.

    This made the preamble helper from indexeddb tests to fail when used
    in places like arrow functions, like in
    storage/indexeddb/result-request-cycle.html.

    This commit makes preamble default to an empty name if the caller is
    null.

    * http/tests/IndexedDB/resources/shared.js:
    (preamble):
    * imported/blink/storage/indexeddb/resources/shared.js:
    (preamble):
    * storage/indexeddb/resources/shared.js:
    (preamble):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

Diff

Modified: branches/safari-611-branch/LayoutTests/ChangeLog (272264 => 272265)


--- branches/safari-611-branch/LayoutTests/ChangeLog	2021-02-03 01:40:21 UTC (rev 272264)
+++ branches/safari-611-branch/LayoutTests/ChangeLog	2021-02-03 01:40:24 UTC (rev 272265)
@@ -1,5 +1,58 @@
 2021-02-02  Alan Coon  <[email protected]>
 
+        Cherry-pick r272030. rdar://problem/73890478
+
+    REGRESSION(r271119) Check for nullness of preamble.caller
+    https://bugs.webkit.org/show_bug.cgi?id=220610
+    
+    Reviewed by Yusuke Suzuki.
+    
+    r271119 changed some kinds of functions to return null when trying to
+    access its caller property.
+    
+    This made the preamble helper from indexeddb tests to fail when used
+    in places like arrow functions, like in
+    storage/indexeddb/result-request-cycle.html.
+    
+    This commit makes preamble default to an empty name if the caller is
+    null.
+    
+    * http/tests/IndexedDB/resources/shared.js:
+    (preamble):
+    * imported/blink/storage/indexeddb/resources/shared.js:
+    (preamble):
+    * storage/indexeddb/resources/shared.js:
+    (preamble):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@272030 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2021-01-28  Lauro Moura  <[email protected]>
+
+            REGRESSION(r271119) Check for nullness of preamble.caller
+            https://bugs.webkit.org/show_bug.cgi?id=220610
+
+            Reviewed by Yusuke Suzuki.
+
+            r271119 changed some kinds of functions to return null when trying to
+            access its caller property.
+
+            This made the preamble helper from indexeddb tests to fail when used
+            in places like arrow functions, like in
+            storage/indexeddb/result-request-cycle.html.
+
+            This commit makes preamble default to an empty name if the caller is
+            null.
+
+            * http/tests/IndexedDB/resources/shared.js:
+            (preamble):
+            * imported/blink/storage/indexeddb/resources/shared.js:
+            (preamble):
+            * storage/indexeddb/resources/shared.js:
+            (preamble):
+
+2021-02-02  Alan Coon  <[email protected]>
+
         Cherry-pick r272004. rdar://problem/73890647
 
     REGRESSION(r268615): images flicker on apple.com/ios/ios-14

Modified: branches/safari-611-branch/LayoutTests/http/tests/IndexedDB/resources/shared.js (272264 => 272265)


--- branches/safari-611-branch/LayoutTests/http/tests/IndexedDB/resources/shared.js	2021-02-03 01:40:21 UTC (rev 272264)
+++ branches/safari-611-branch/LayoutTests/http/tests/IndexedDB/resources/shared.js	2021-02-03 01:40:24 UTC (rev 272265)
@@ -146,7 +146,8 @@
     if (evt)
         event = evt;
     debug("");
-    debug(preamble.caller.name + "():");
+    var name = preamble.caller?.name ?? '';
+    debug(name + "():");
 }
 
 // For Workers

Modified: branches/safari-611-branch/LayoutTests/imported/blink/storage/indexeddb/resources/shared.js (272264 => 272265)


--- branches/safari-611-branch/LayoutTests/imported/blink/storage/indexeddb/resources/shared.js	2021-02-03 01:40:21 UTC (rev 272264)
+++ branches/safari-611-branch/LayoutTests/imported/blink/storage/indexeddb/resources/shared.js	2021-02-03 01:40:24 UTC (rev 272265)
@@ -130,7 +130,8 @@
     if (evt)
         event = evt;
     debug("");
-    debug(preamble.caller.name + "():");
+    var name = preamble.caller?.name ?? '';
+    debug(name + "():");
 }
 
 // For Workers

Modified: branches/safari-611-branch/LayoutTests/storage/indexeddb/resources/shared.js (272264 => 272265)


--- branches/safari-611-branch/LayoutTests/storage/indexeddb/resources/shared.js	2021-02-03 01:40:21 UTC (rev 272264)
+++ branches/safari-611-branch/LayoutTests/storage/indexeddb/resources/shared.js	2021-02-03 01:40:24 UTC (rev 272265)
@@ -146,7 +146,8 @@
     if (evt)
         event = evt;
     debug("");
-    debug(preamble.caller.name + "():");
+    var name = preamble.caller?.name ?? '';
+    debug(name + "():");
 }
 
 // For Workers

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to