Title: [272267] branches/safari-611-branch/Source/WebCore
- Revision
- 272267
- Author
- [email protected]
- Date
- 2021-02-02 17:40:30 -0800 (Tue, 02 Feb 2021)
Log Message
Cherry-pick r271744. rdar://problem/73886483
Denying storage access on playstation.com then clicking sign-in fails to show the prompt again
https://bugs.webkit.org/show_bug.cgi?id=220838
<rdar://problem/73477444>
Reviewed by Alex Christensen.
Temporary cross-page storage access in the Web Process for quirks
should only be granted if the user hits "Allow" on the prompt.
This was causing the prompt to fail to show if a user clicks "Don't
Allow" then tries to sign in, then sign-in would fail without
storage access in the Network Process.
* page/Quirks.cpp:
(WebCore::Quirks::requestStorageAccessAndHandleClick const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WebCore/ChangeLog (272266 => 272267)
--- branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-03 01:40:27 UTC (rev 272266)
+++ branches/safari-611-branch/Source/WebCore/ChangeLog 2021-02-03 01:40:30 UTC (rev 272267)
@@ -1,5 +1,44 @@
2021-02-02 Alan Coon <[email protected]>
+ Cherry-pick r271744. rdar://problem/73886483
+
+ Denying storage access on playstation.com then clicking sign-in fails to show the prompt again
+ https://bugs.webkit.org/show_bug.cgi?id=220838
+ <rdar://problem/73477444>
+
+ Reviewed by Alex Christensen.
+
+ Temporary cross-page storage access in the Web Process for quirks
+ should only be granted if the user hits "Allow" on the prompt.
+ This was causing the prompt to fail to show if a user clicks "Don't
+ Allow" then tries to sign in, then sign-in would fail without
+ storage access in the Network Process.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::requestStorageAccessAndHandleClick const):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271744 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-22 Kate Cheney <[email protected]>
+
+ Denying storage access on playstation.com then clicking sign-in fails to show the prompt again
+ https://bugs.webkit.org/show_bug.cgi?id=220838
+ <rdar://problem/73477444>
+
+ Reviewed by Alex Christensen.
+
+ Temporary cross-page storage access in the Web Process for quirks
+ should only be granted if the user hits "Allow" on the prompt.
+ This was causing the prompt to fail to show if a user clicks "Don't
+ Allow" then tries to sign in, then sign-in would fail without
+ storage access in the Network Process.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::requestStorageAccessAndHandleClick const):
+
+2021-02-02 Alan Coon <[email protected]>
+
Cherry-pick r272004. rdar://problem/73890647
REGRESSION(r268615): images flicker on apple.com/ios/ios-14
Modified: branches/safari-611-branch/Source/WebCore/page/Quirks.cpp (272266 => 272267)
--- branches/safari-611-branch/Source/WebCore/page/Quirks.cpp 2021-02-03 01:40:27 UTC (rev 272266)
+++ branches/safari-611-branch/Source/WebCore/page/Quirks.cpp 2021-02-03 01:40:30 UTC (rev 272267)
@@ -1055,6 +1055,11 @@
}
DocumentStorageAccess::requestStorageAccessForNonDocumentQuirk(*m_document, WTFMove(domainInNeedOfStorageAccess), [firstPartyDomain, domainInNeedOfStorageAccess, completionHandler = WTFMove(completionHandler)](StorageAccessWasGranted storageAccessGranted) mutable {
+ if (storageAccessGranted == StorageAccessWasGranted::No) {
+ completionHandler(storageAccessGranted);
+ return;
+ }
+
ResourceLoadObserver::shared().setDomainsWithCrossPageStorageAccess({{ firstPartyDomain, domainInNeedOfStorageAccess }}, [storageAccessGranted, completionHandler = WTFMove(completionHandler)] () mutable {
completionHandler(storageAccessGranted);
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
