Title: [272281] branches/safari-611-branch/Source/WebInspectorUI
- Revision
- 272281
- Author
- [email protected]
- Date
- 2021-02-02 17:41:24 -0800 (Tue, 02 Feb 2021)
Log Message
Cherry-pick r271927. rdar://problem/73887777
REGRESSION(r270637) Filtering does not work in Styles sidebar panel
https://bugs.webkit.org/show_bug.cgi?id=220993
<rdar://problem/73623818>
Patch by Razvan Caliman <[email protected]> on 2021-01-26
Reviewed by Devin Rousso.
Stop expecting StyleDetailsPanel to define an abstract filterDidChange() method.
Subclasses implement their own on a per-use case basis.
* UserInterface/Views/ComputedStyleDetailsPanel.js:
(WI.ComputedStyleDetailsPanel.prototype.filterDidChange):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WebInspectorUI/ChangeLog (272280 => 272281)
--- branches/safari-611-branch/Source/WebInspectorUI/ChangeLog 2021-02-03 01:41:22 UTC (rev 272280)
+++ branches/safari-611-branch/Source/WebInspectorUI/ChangeLog 2021-02-03 01:41:24 UTC (rev 272281)
@@ -1,5 +1,42 @@
2021-02-02 Alan Coon <[email protected]>
+ Cherry-pick r271927. rdar://problem/73887777
+
+ REGRESSION(r270637) Filtering does not work in Styles sidebar panel
+ https://bugs.webkit.org/show_bug.cgi?id=220993
+ <rdar://problem/73623818>
+
+ Patch by Razvan Caliman <[email protected]> on 2021-01-26
+ Reviewed by Devin Rousso.
+
+ Stop expecting StyleDetailsPanel to define an abstract filterDidChange() method.
+ Subclasses implement their own on a per-use case basis.
+
+ * UserInterface/Views/ComputedStyleDetailsPanel.js:
+ (WI.ComputedStyleDetailsPanel.prototype.filterDidChange):
+ * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+ (WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271927 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-26 Razvan Caliman <[email protected]>
+
+ REGRESSION(r270637) Filtering does not work in Styles sidebar panel
+ https://bugs.webkit.org/show_bug.cgi?id=220993
+ <rdar://problem/73623818>
+
+ Reviewed by Devin Rousso.
+
+ Stop expecting StyleDetailsPanel to define an abstract filterDidChange() method.
+ Subclasses implement their own on a per-use case basis.
+
+ * UserInterface/Views/ComputedStyleDetailsPanel.js:
+ (WI.ComputedStyleDetailsPanel.prototype.filterDidChange):
+ * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+ (WI.SpreadsheetRulesStyleDetailsPanel.prototype.filterDidChange):
+
+2021-02-02 Alan Coon <[email protected]>
+
Cherry-pick r271726. rdar://problem/73889694
Web Inspector: Fix bidi confusion when evaluation result has RTL text
Modified: branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js (272280 => 272281)
--- branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2021-02-03 01:41:22 UTC (rev 272280)
+++ branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsPanel.js 2021-02-03 01:41:24 UTC (rev 272281)
@@ -149,8 +149,6 @@
filterDidChange(filterBar)
{
- super.filterDidChange(filterBar);
-
this.applyFilter(filterBar.filters.text);
}
Modified: branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js (272280 => 272281)
--- branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-02-03 01:41:22 UTC (rev 272280)
+++ branches/safari-611-branch/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-02-03 01:41:24 UTC (rev 272281)
@@ -320,8 +320,6 @@
filterDidChange(filterBar)
{
- super.filterDidChange(filterBar);
-
this.applyFilter(filterBar.filters.text);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
