Title: [272280] branches/safari-611-branch/Source
- Revision
- 272280
- Author
- [email protected]
- Date
- 2021-02-02 17:41:22 -0800 (Tue, 02 Feb 2021)
Log Message
Cherry-pick r271926. rdar://problem/73889676
REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
https://bugs.webkit.org/show_bug.cgi?id=220996
<rdar://72173139>
Reviewed by Sam Weinig.
Source/WebKitLegacy/mac:
Read back this preference when propagating it, because the value depends on
more than just the preference key. For example, it allows Debug builds to act
as if the preference is always enabled.
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WTF:
This preference should use custom bindings for WebKitLegacy.
* Scripts/Preferences/WebPreferencesDebug.yaml:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/WTF/ChangeLog (272279 => 272280)
--- branches/safari-611-branch/Source/WTF/ChangeLog 2021-02-03 01:41:19 UTC (rev 272279)
+++ branches/safari-611-branch/Source/WTF/ChangeLog 2021-02-03 01:41:22 UTC (rev 272280)
@@ -1,3 +1,43 @@
+2021-02-02 Alan Coon <[email protected]>
+
+ Cherry-pick r271926. rdar://problem/73889676
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ Source/WebKitLegacy/mac:
+
+ Read back this preference when propagating it, because the value depends on
+ more than just the preference key. For example, it allows Debug builds to act
+ as if the preference is always enabled.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
+ Source/WTF:
+
+ This preference should use custom bindings for WebKitLegacy.
+
+ * Scripts/Preferences/WebPreferencesDebug.yaml:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-26 BJ Burg <[email protected]>
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ This preference should use custom bindings for WebKitLegacy.
+
+ * Scripts/Preferences/WebPreferencesDebug.yaml:
+
2021-01-26 Dean Jackson <[email protected]>
Disable WebGL 2 on safari-611-branch
Modified: branches/safari-611-branch/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml (272279 => 272280)
--- branches/safari-611-branch/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml 2021-02-03 01:41:19 UTC (rev 272279)
+++ branches/safari-611-branch/Source/WTF/Scripts/Preferences/WebPreferencesDebug.yaml 2021-02-03 01:41:22 UTC (rev 272280)
@@ -65,6 +65,7 @@
DeveloperExtrasEnabled:
type: bool
webKitLegacyPreferenceKey: WebKitDeveloperExtrasEnabledPreferenceKey
+ webKitLegacyBinding: custom
defaultValue:
WebKitLegacy:
default: false
Modified: branches/safari-611-branch/Source/WebKitLegacy/mac/ChangeLog (272279 => 272280)
--- branches/safari-611-branch/Source/WebKitLegacy/mac/ChangeLog 2021-02-03 01:41:19 UTC (rev 272279)
+++ branches/safari-611-branch/Source/WebKitLegacy/mac/ChangeLog 2021-02-03 01:41:22 UTC (rev 272280)
@@ -1,3 +1,46 @@
+2021-02-02 Alan Coon <[email protected]>
+
+ Cherry-pick r271926. rdar://problem/73889676
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ Source/WebKitLegacy/mac:
+
+ Read back this preference when propagating it, because the value depends on
+ more than just the preference key. For example, it allows Debug builds to act
+ as if the preference is always enabled.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
+ Source/WTF:
+
+ This preference should use custom bindings for WebKitLegacy.
+
+ * Scripts/Preferences/WebPreferencesDebug.yaml:
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-26 BJ Burg <[email protected]>
+
+ REGRESSION(r267641): WebKitDeveloperExtras preference has no effect for WebKitLegacy clients
+ https://bugs.webkit.org/show_bug.cgi?id=220996
+ <rdar://72173139>
+
+ Reviewed by Sam Weinig.
+
+ Read back this preference when propagating it, because the value depends on
+ more than just the preference key. For example, it allows Debug builds to act
+ as if the preference is always enabled.
+
+ * WebView/WebView.mm:
+ (-[WebView _preferencesChanged:]):
+
2021-01-07 Alexey Shvayka <[email protected]>
[JSC] Simplify get*PropertyNames() methods and EnumerationMode
Modified: branches/safari-611-branch/Source/WebKitLegacy/mac/WebView/WebView.mm (272279 => 272280)
--- branches/safari-611-branch/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-02-03 01:41:19 UTC (rev 272279)
+++ branches/safari-611-branch/Source/WebKitLegacy/mac/WebView/WebView.mm 2021-02-03 01:41:22 UTC (rev 272280)
@@ -2926,6 +2926,9 @@
settings.setBackForwardCacheExpirationInterval(Seconds { [preferences _backForwardCacheExpirationInterval] });
settings.setPitchCorrectionAlgorithm(static_cast<WebCore::MediaPlayerEnums::PitchCorrectionAlgorithm>([preferences _pitchCorrectionAlgorithm]));
+ // FIXME: Add a way to have a preference check multiple different keys.
+ settings.setDeveloperExtrasEnabled([preferences developerExtrasEnabled]);
+
BOOL mediaPlaybackRequiresUserGesture = [preferences mediaPlaybackRequiresUserGesture];
settings.setVideoPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences videoPlaybackRequiresUserGesture]);
settings.setAudioPlaybackRequiresUserGesture(mediaPlaybackRequiresUserGesture || [preferences audioPlaybackRequiresUserGesture]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
