Title: [272408] trunk/Source/WebKit
Revision
272408
Author
[email protected]
Date
2021-02-05 03:02:49 -0800 (Fri, 05 Feb 2021)

Log Message

[GTK] clang warnings
https://bugs.webkit.org/show_bug.cgi?id=221410

Reviewed by Adrian Perez de Castro.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::resourceLoadInfo): Remove ifdef added in r272313, the
corresponding enum value is not ifdeffed either.
* UIProcess/SpeechRecognitionServer.cpp:
(WebKit::SpeechRecognitionServer::sendUpdate): Use portable format specifier for uint64_t.
* WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp: Ifdef member variable
currently used only on Cocoa platforms.

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (272407 => 272408)


--- trunk/Source/WebKit/ChangeLog	2021-02-05 10:03:29 UTC (rev 272407)
+++ trunk/Source/WebKit/ChangeLog	2021-02-05 11:02:49 UTC (rev 272408)
@@ -1,3 +1,18 @@
+2021-02-05  Philippe Normand  <[email protected]>
+
+        [GTK] clang warnings
+        https://bugs.webkit.org/show_bug.cgi?id=221410
+
+        Reviewed by Adrian Perez de Castro.
+
+        * NetworkProcess/NetworkResourceLoader.cpp:
+        (WebKit::NetworkResourceLoader::resourceLoadInfo): Remove ifdef added in r272313, the
+        corresponding enum value is not ifdeffed either.
+        * UIProcess/SpeechRecognitionServer.cpp:
+        (WebKit::SpeechRecognitionServer::sendUpdate): Use portable format specifier for uint64_t.
+        * WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp: Ifdef member variable
+        currently used only on Cocoa platforms.
+
 2021-02-04  Adrian Perez de Castro  <[email protected]>
 
         Unreviewed. Update OptionsWPE.cmake and NEWS for the 2.31.1 release

Modified: trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp (272407 => 272408)


--- trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2021-02-05 10:03:29 UTC (rev 272407)
+++ trunk/Source/WebKit/NetworkProcess/NetworkResourceLoader.cpp	2021-02-05 11:02:49 UTC (rev 272408)
@@ -392,10 +392,8 @@
             return ResourceLoadInfo::Type::Image;
         case WebCore::FetchOptions::Destination::Manifest:
             return ResourceLoadInfo::Type::ApplicationManifest;
-#if ENABLE(MODEL_ELEMENT)
         case WebCore::FetchOptions::Destination::Model:
             return ResourceLoadInfo::Type::Media;
-#endif
         case WebCore::FetchOptions::Destination::Object:
             return ResourceLoadInfo::Type::Object;
         case WebCore::FetchOptions::Destination::Paintworklet:

Modified: trunk/Source/WebKit/UIProcess/SpeechRecognitionServer.cpp (272407 => 272408)


--- trunk/Source/WebKit/UIProcess/SpeechRecognitionServer.cpp	2021-02-05 10:03:29 UTC (rev 272407)
+++ trunk/Source/WebKit/UIProcess/SpeechRecognitionServer.cpp	2021-02-05 11:02:49 UTC (rev 272408)
@@ -159,7 +159,7 @@
 
 void SpeechRecognitionServer::sendUpdate(const WebCore::SpeechRecognitionUpdate& update)
 {
-    WTFLogAlways("[%p]SpeechRecognitionServer::sendUpdate update.type[%d], update.clientIdentifier[%llu]", this, update.type(), update.clientIdentifier().toUInt64());
+    WTFLogAlways("[%p]SpeechRecognitionServer::sendUpdate update.type[%d], update.clientIdentifier[%" PRIu64 "]", this, update.type(), update.clientIdentifier().toUInt64());
     send(Messages::WebSpeechRecognitionConnection::DidReceiveUpdate(update));
 }
 

Modified: trunk/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp (272407 => 272408)


--- trunk/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-02-05 10:03:29 UTC (rev 272407)
+++ trunk/Source/WebKit/WebProcess/Speech/SpeechRecognitionRealtimeMediaSourceManager.cpp	2021-02-05 11:02:49 UTC (rev 272408)
@@ -157,9 +157,9 @@
     RealtimeMediaSourceIdentifier m_identifier;
     Ref<RealtimeMediaSource> m_source;
     Ref<IPC::Connection> m_connection;
-    uint64_t m_numberOfFrames { 0 };
 
 #if PLATFORM(COCOA)
+    uint64_t m_numberOfFrames { 0 };
     CARingBuffer m_ringBuffer;
     CAAudioStreamDescription m_description { };
 #endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to