Title: [272409] trunk
- Revision
- 272409
- Author
- [email protected]
- Date
- 2021-02-05 05:22:38 -0800 (Fri, 05 Feb 2021)
Log Message
REGRESSION(r271879) [SOUP] webrtc/datachannel/gather-candidates-networkprocess-crash.html is crashing in debug mode
https://bugs.webkit.org/show_bug.cgi?id=221379
Reviewed by Youenn Fablet.
Source/WebKit:
* NetworkProcess/soup/WebKitDirectoryInputStream.cpp:
(webkitDirectoryInputStreamRead): Fix bytes read calculation.
LayoutTests:
Remove expectations for tests that are now passing.
* platform/glib/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (272408 => 272409)
--- trunk/LayoutTests/ChangeLog 2021-02-05 11:02:49 UTC (rev 272408)
+++ trunk/LayoutTests/ChangeLog 2021-02-05 13:22:38 UTC (rev 272409)
@@ -1,3 +1,14 @@
+2021-02-05 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r271879) [SOUP] webrtc/datachannel/gather-candidates-networkprocess-crash.html is crashing in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=221379
+
+ Reviewed by Youenn Fablet.
+
+ Remove expectations for tests that are now passing.
+
+ * platform/glib/TestExpectations:
+
2021-02-05 Devin Rousso <[email protected]>
Add intermediate volume icon states between "mute" and "max"
Modified: trunk/LayoutTests/platform/glib/TestExpectations (272408 => 272409)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-02-05 11:02:49 UTC (rev 272408)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-02-05 13:22:38 UTC (rev 272409)
@@ -949,13 +949,10 @@
webkit.org/b/194611 http/wpt/webrtc/getUserMedia-processSwapping.html [ Failure ]
webkit.org/b/201267 [ Release ] webrtc/video-h264.html [ Failure ]
-webkit.org/b/221379 [ Debug ] webrtc/video-h264.html [ Crash ]
webkit.org/b/210272 webrtc/datachannel/multiple-connections.html [ Timeout Pass ]
webkit.org/b/212809 [ Release ] webrtc/datachannel/gather-candidates-networkprocess-crash.html [ Timeout Pass ]
-webkit.org/b/221379 [ Debug ] webrtc/datachannel/gather-candidates-networkprocess-crash.html [ Crash ]
-
webkit.org/b/213780 webrtc/vp9.html [ Failure ]
webkit.org/b/215005 webkit.org/b/218787 webrtc/h264-baseline.html [ Crash Timeout ]
Modified: trunk/Source/WebKit/ChangeLog (272408 => 272409)
--- trunk/Source/WebKit/ChangeLog 2021-02-05 11:02:49 UTC (rev 272408)
+++ trunk/Source/WebKit/ChangeLog 2021-02-05 13:22:38 UTC (rev 272409)
@@ -1,3 +1,13 @@
+2021-02-05 Carlos Garcia Campos <[email protected]>
+
+ REGRESSION(r271879) [SOUP] webrtc/datachannel/gather-candidates-networkprocess-crash.html is crashing in debug mode
+ https://bugs.webkit.org/show_bug.cgi?id=221379
+
+ Reviewed by Youenn Fablet.
+
+ * NetworkProcess/soup/WebKitDirectoryInputStream.cpp:
+ (webkitDirectoryInputStreamRead): Fix bytes read calculation.
+
2021-02-05 Philippe Normand <[email protected]>
[GTK] clang warnings
Modified: trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp (272408 => 272409)
--- trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp 2021-02-05 11:02:49 UTC (rev 272408)
+++ trunk/Source/WebKit/NetworkProcess/soup/WebKitDirectoryInputStream.cpp 2021-02-05 13:22:38 UTC (rev 272409)
@@ -150,7 +150,7 @@
gsize bufferSize;
auto* bufferData = g_bytes_get_data(stream->priv->buffer.get(), &bufferSize);
- gsize bytesRead = std::min(bufferSize, totalBytesRead - count);
+ gsize bytesRead = std::min(bufferSize, count - totalBytesRead);
memcpy(reinterpret_cast<char*>(buffer) + totalBytesRead, bufferData, bytesRead);
if (bytesRead == bufferSize)
stream->priv->buffer = nullptr;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
