Title: [272410] trunk/Source/WebCore
- Revision
- 272410
- Author
- [email protected]
- Date
- 2021-02-05 05:23:55 -0800 (Fri, 05 Feb 2021)
Log Message
[SOUP] Fix error handling in WebKitFormDataInputStream
https://bugs.webkit.org/show_bug.cgi?id=221459
Reviewed by Adrian Perez de Castro.
We are checking the error parameter passed, that can be nullptr when not provided, we should be checking the
return value of g_input_stream_read() instead.
* platform/network/soup/WebKitFormDataInputStream.cpp:
(webkitFormDataInputStreamRead):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (272409 => 272410)
--- trunk/Source/WebCore/ChangeLog 2021-02-05 13:22:38 UTC (rev 272409)
+++ trunk/Source/WebCore/ChangeLog 2021-02-05 13:23:55 UTC (rev 272410)
@@ -1,3 +1,16 @@
+2021-02-05 Carlos Garcia Campos <[email protected]>
+
+ [SOUP] Fix error handling in WebKitFormDataInputStream
+ https://bugs.webkit.org/show_bug.cgi?id=221459
+
+ Reviewed by Adrian Perez de Castro.
+
+ We are checking the error parameter passed, that can be nullptr when not provided, we should be checking the
+ return value of g_input_stream_read() instead.
+
+ * platform/network/soup/WebKitFormDataInputStream.cpp:
+ (webkitFormDataInputStreamRead):
+
2021-02-04 Julian Gonzalez <[email protected]>
Null dereference in DocumentLoader::commitData()
Modified: trunk/Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp (272409 => 272410)
--- trunk/Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp 2021-02-05 13:22:38 UTC (rev 272409)
+++ trunk/Source/WebCore/platform/network/soup/WebKitFormDataInputStream.cpp 2021-02-05 13:23:55 UTC (rev 272410)
@@ -89,7 +89,7 @@
bytesToRead = priv->currentStreamRangeLength;
auto bytesRead = g_input_stream_read(priv->currentStream.get(), buffer, bytesToRead, cancellable, error);
- if (error)
+ if (bytesRead == -1)
return bytesRead;
if (bytesRead) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
