[webkit-changes] [273258] branches/safari-611-branch/Source/JavaScriptCore

[alancoon]

Title: [273258] branches/safari-611-branch/Source/_javascript_Core

Revision

273258

Author

alanc...@apple.com

Date

2021-02-22 09:55:12 -0800 (Mon, 22 Feb 2021)

Log Message

Cherry-pick r270719. rdar://problem/74409412

    REGRESSION (r270665): testapi failing on JSC bots
    https://bugs.webkit.org/show_bug.cgi?id=219787

    Reviewed by Saam Barati.

    * API/JSValueRef.cpp:
    (JSValueIsString):
    (JSValueIsObject):
    (JSValueIsSymbol):

    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Modified Paths

• branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp
• branches/safari-611-branch/Source/_javascript_Core/ChangeLog

Diff

Modified: branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp (273257 => 273258)

--- branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp	2021-02-22 17:55:10 UTC (rev 273257)
+++ branches/safari-611-branch/Source/_javascript_Core/API/JSValueRef.cpp	2021-02-22 17:55:12 UTC (rev 273258)
@@ -150,7 +150,7 @@
     JSLockHolder locker(globalObject);
     return toJS(globalObject, value).isString();
 #else
-    return toJS(value).isString();
+    return value && toJS(value).isString();
 #endif
 }
 
@@ -165,7 +165,7 @@
     JSLockHolder locker(globalObject);
     return toJS(globalObject, value).isObject();
 #else
-    return toJS(value).isObject();
+    return value && toJS(value).isObject();
 #endif
 }
 
@@ -180,7 +180,7 @@
     JSLockHolder locker(globalObject);
     return toJS(globalObject, value).isSymbol();
 #else
-    return toJS(value).isSymbol();
+    return value && toJS(value).isSymbol();
 #endif
 }
 

Modified: branches/safari-611-branch/Source/_javascript_Core/ChangeLog (273257 => 273258)

--- branches/safari-611-branch/Source/_javascript_Core/ChangeLog	2021-02-22 17:55:10 UTC (rev 273257)
+++ branches/safari-611-branch/Source/_javascript_Core/ChangeLog	2021-02-22 17:55:12 UTC (rev 273258)
@@ -1,5 +1,34 @@
 2021-02-17  Ruben Turcios  <rubent...@apple.com>
 
+        Cherry-pick r270719. rdar://problem/74409412
+
+    REGRESSION (r270665): testapi failing on JSC bots
+    https://bugs.webkit.org/show_bug.cgi?id=219787
+    
+    Reviewed by Saam Barati.
+    
+    * API/JSValueRef.cpp:
+    (JSValueIsString):
+    (JSValueIsObject):
+    (JSValueIsSymbol):
+    
+    
+    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@270719 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+    2020-12-11  Tadeu Zagallo  <tzaga...@apple.com>
+
+            REGRESSION (r270665): testapi failing on JSC bots
+            https://bugs.webkit.org/show_bug.cgi?id=219787
+
+            Reviewed by Saam Barati.
+
+            * API/JSValueRef.cpp:
+            (JSValueIsString):
+            (JSValueIsObject):
+            (JSValueIsSymbol):
+
+2021-02-17  Ruben Turcios  <rubent...@apple.com>
+
         Cherry-pick r270700. rdar://problem/74409412
 
     REGRESSION (r270665): testapi failing on CLoop bot

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes