Title: [273259] branches/safari-611-branch/Source/_javascript_Core
- Revision
- 273259
- Author
- [email protected]
- Date
- 2021-02-22 09:55:15 -0800 (Mon, 22 Feb 2021)
Log Message
Cherry-pick r271767. rdar://problem/74409412
Obj-C API should do correct type checks when using a 32-bit address space
https://bugs.webkit.org/show_bug.cgi?id=220880
<rdar://72370334>
Reviewed by Tadeu Zagallo.
* API/JSValue.mm:
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Modified Paths
Diff
Modified: branches/safari-611-branch/Source/_javascript_Core/API/JSValue.mm (273258 => 273259)
--- branches/safari-611-branch/Source/_javascript_Core/API/JSValue.mm 2021-02-22 17:55:12 UTC (rev 273258)
+++ branches/safari-611-branch/Source/_javascript_Core/API/JSValue.mm 2021-02-22 17:55:15 UTC (rev 273259)
@@ -408,7 +408,7 @@
- (BOOL)isNull
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsNull([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isNull();
#endif
@@ -417,7 +417,7 @@
- (BOOL)isBoolean
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsBoolean([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isBoolean();
#endif
@@ -426,7 +426,7 @@
- (BOOL)isNumber
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsNumber([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isNumber();
#endif
@@ -435,7 +435,7 @@
- (BOOL)isString
{
#if !CPU(ADDRESS64)
- return JSValueIsUndefined([_context JSGlobalContextRef], m_value);
+ return JSValueIsString([_context JSGlobalContextRef], m_value);
#else
return toJS(m_value).isString();
#endif
Modified: branches/safari-611-branch/Source/_javascript_Core/ChangeLog (273258 => 273259)
--- branches/safari-611-branch/Source/_javascript_Core/ChangeLog 2021-02-22 17:55:12 UTC (rev 273258)
+++ branches/safari-611-branch/Source/_javascript_Core/ChangeLog 2021-02-22 17:55:15 UTC (rev 273259)
@@ -1,5 +1,38 @@
2021-02-17 Ruben Turcios <[email protected]>
+ Cherry-pick r271767. rdar://problem/74409412
+
+ Obj-C API should do correct type checks when using a 32-bit address space
+ https://bugs.webkit.org/show_bug.cgi?id=220880
+ <rdar://72370334>
+
+ Reviewed by Tadeu Zagallo.
+
+ * API/JSValue.mm:
+ (-[JSValue isNull]):
+ (-[JSValue isBoolean]):
+ (-[JSValue isNumber]):
+ (-[JSValue isString]):
+
+
+ git-svn-id: https://svn.webkit.org/repository/webkit/trunk@271767 268f45cc-cd09-0410-ab3c-d52691b4dbfc
+
+ 2021-01-22 Keith Miller <[email protected]>
+
+ Obj-C API should do correct type checks when using a 32-bit address space
+ https://bugs.webkit.org/show_bug.cgi?id=220880
+ <rdar://72370334>
+
+ Reviewed by Tadeu Zagallo.
+
+ * API/JSValue.mm:
+ (-[JSValue isNull]):
+ (-[JSValue isBoolean]):
+ (-[JSValue isNumber]):
+ (-[JSValue isString]):
+
+2021-02-17 Ruben Turcios <[email protected]>
+
Cherry-pick r270719. rdar://problem/74409412
REGRESSION (r270665): testapi failing on JSC bots
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
