Title: [275218] trunk/Tools
- Revision
- 275218
- Author
- [email protected]
- Date
- 2021-03-30 11:54:12 -0700 (Tue, 30 Mar 2021)
Log Message
[ews] Make RunWebKitTests class easy to extend
https://bugs.webkit.org/show_bug.cgi?id=223939
Reviewed by Jonathan Bedard.
* CISupport/ews-build/steps.py:
(RunWebKitTests):
(RunWebKitTests.setLayoutTestCommand): Separated out code to set the layout-test command.
(RunWebKitTests.start):
Modified Paths
Diff
Modified: trunk/Tools/CISupport/ews-build/steps.py (275217 => 275218)
--- trunk/Tools/CISupport/ews-build/steps.py 2021-03-30 18:47:17 UTC (rev 275217)
+++ trunk/Tools/CISupport/ews-build/steps.py 2021-03-30 18:54:12 UTC (rev 275218)
@@ -2063,6 +2063,7 @@
jsonFileName = 'layout-test-results/full_results.json'
logfiles = {'json': jsonFileName}
test_failures_log_name = 'test-failures'
+ EXIT_AFTER_FAILURES = '30'
command = ['python', 'Tools/Scripts/run-webkit-tests',
'--no-build',
'--no-show-results',
@@ -2084,12 +2085,7 @@
return not ((self.getProperty('buildername', '').lower() == 'commit-queue') and
(self.getProperty('revert') or self.getProperty('passed_mac_wk2')))
- def start(self):
- self.log_observer = logobserver.BufferLogObserver(wantStderr=True)
- self.addLogObserver('stdio', self.log_observer)
- self.log_observer_json = logobserver.BufferLogObserver()
- self.addLogObserver('json', self.log_observer_json)
-
+ def setLayoutTestCommand(self):
platform = self.getProperty('platform')
appendCustomBuildFlags(self, platform, self.getProperty('fullPlatform'))
additionalArguments = self.getProperty('additionalArguments')
@@ -2104,7 +2100,7 @@
if patch_author in ['[email protected]']:
self.setCommand(self.command + ['imported/w3c/web-platform-tests'])
else:
- self.setCommand(self.command + ['--exit-after-n-failures', '30', '--skip-failing-tests'])
+ self.setCommand(self.command + ['--exit-after-n-failures', self.EXIT_AFTER_FAILURES, '--skip-failing-tests'])
if additionalArguments:
self.setCommand(self.command + additionalArguments)
@@ -2134,6 +2130,12 @@
list_retry_tests = sorted(first_results_failing_tests.union(second_results_failing_tests))
self.setCommand(self.command + list_retry_tests)
+ def start(self):
+ self.log_observer = logobserver.BufferLogObserver(wantStderr=True)
+ self.addLogObserver('stdio', self.log_observer)
+ self.log_observer_json = logobserver.BufferLogObserver()
+ self.addLogObserver('json', self.log_observer_json)
+ self.setLayoutTestCommand()
return shell.Test.start(self)
# FIXME: This will break if run-webkit-tests changes its default log formatter.
Modified: trunk/Tools/ChangeLog (275217 => 275218)
--- trunk/Tools/ChangeLog 2021-03-30 18:47:17 UTC (rev 275217)
+++ trunk/Tools/ChangeLog 2021-03-30 18:54:12 UTC (rev 275218)
@@ -1,3 +1,15 @@
+2021-03-30 Aakash Jain <[email protected]>
+
+ [ews] Make RunWebKitTests class easy to extend
+ https://bugs.webkit.org/show_bug.cgi?id=223939
+
+ Reviewed by Jonathan Bedard.
+
+ * CISupport/ews-build/steps.py:
+ (RunWebKitTests):
+ (RunWebKitTests.setLayoutTestCommand): Separated out code to set the layout-test command.
+ (RunWebKitTests.start):
+
2021-03-29 Simon Fraser <[email protected]>
Allow non-60fps display updates to be driven by DisplayRefreshMonitor
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
