Title: [275219] trunk/Source/WebKit
- Revision
- 275219
- Author
- [email protected]
- Date
- 2021-03-30 11:56:02 -0700 (Tue, 30 Mar 2021)
Log Message
Unreviewed, reverting r275197.
The change is spooky.
Reverted changeset:
"Safari crashed and lost all tabs, after unlocking sleeping
device"
https://bugs.webkit.org/show_bug.cgi?id=223832
https://commits.webkit.org/r275197
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275218 => 275219)
--- trunk/Source/WebKit/ChangeLog 2021-03-30 18:54:12 UTC (rev 275218)
+++ trunk/Source/WebKit/ChangeLog 2021-03-30 18:56:02 UTC (rev 275219)
@@ -1,3 +1,16 @@
+2021-03-30 Jiewen Tan <[email protected]>
+
+ Unreviewed, reverting r275197.
+
+ The change is spooky.
+
+ Reverted changeset:
+
+ "Safari crashed and lost all tabs, after unlocking sleeping
+ device"
+ https://bugs.webkit.org/show_bug.cgi?id=223832
+ https://commits.webkit.org/r275197
+
2021-03-30 Aditya Keerthi <[email protected]>
[iOS] Two taps required to view <select> options on Square Checkout
Modified: trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm (275218 => 275219)
--- trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm 2021-03-30 18:54:12 UTC (rev 275218)
+++ trunk/Source/WebKit/UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm 2021-03-30 18:56:02 UTC (rev 275219)
@@ -302,10 +302,10 @@
if (presentingWindow.miniaturized) {
if (m_presentingWindowDidDeminiaturizeObserver)
return;
- m_presentingWindowDidDeminiaturizeObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSWindowDidDeminiaturizeNotification object:presentingWindow queue:nil usingBlock:[protectedThis = makeRef(*this)] (NSNotification *) {
- protectedThis->dismissViewController();
- [[NSNotificationCenter defaultCenter] removeObserver:protectedThis->m_presentingWindowDidDeminiaturizeObserver.get()];
- protectedThis->m_presentingWindowDidDeminiaturizeObserver = nullptr;
+ m_presentingWindowDidDeminiaturizeObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSWindowDidDeminiaturizeNotification object:presentingWindow queue:nil usingBlock:[protectedThis = makeRefPtr(this), this] (NSNotification *) {
+ dismissViewController();
+ [[NSNotificationCenter defaultCenter] removeObserver:m_presentingWindowDidDeminiaturizeObserver.get()];
+ m_presentingWindowDidDeminiaturizeObserver = nullptr;
}];
return;
}
@@ -314,10 +314,10 @@
if (NSApp.hidden) {
if (m_applicationDidUnhideObserver)
return;
- m_applicationDidUnhideObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationDidUnhideNotification object:NSApp queue:nil usingBlock:[protectedThis = makeRef(*this)] (NSNotification *) {
- protectedThis->dismissViewController();
- [[NSNotificationCenter defaultCenter] removeObserver:protectedThis->m_applicationDidUnhideObserver.get()];
- protectedThis->m_applicationDidUnhideObserver = nullptr;
+ m_applicationDidUnhideObserver = [[NSNotificationCenter defaultCenter] addObserverForName:NSApplicationDidUnhideNotification object:NSApp queue:nil usingBlock:[protectedThis = makeRefPtr(this), this] (NSNotification *) {
+ dismissViewController();
+ [[NSNotificationCenter defaultCenter] removeObserver:m_applicationDidUnhideObserver.get()];
+ m_applicationDidUnhideObserver = nullptr;
}];
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
