Title: [276923] trunk/Tools
- Revision
- 276923
- Author
- [email protected]
- Date
- 2021-05-03 14:11:43 -0700 (Mon, 03 May 2021)
Log Message
REGRESSION(r275810): [WebKitTestRunner] fast/text/basic/004.html fails after running fast/layoutformattingcontext tests
https://bugs.webkit.org/show_bug.cgi?id=225087
Reviewed by Don Olmstead.
fast/layoutformattingcontext tests enable some internal debug
settings by using the test file header. These settings weren't
reset after running the tests.
r275810 changed resetPreferencesToConsistentValues not to call
WKPreferencesResetAllInternalDebugFeatures.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
Call WKPreferencesResetAllInternalDebugFeatures.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (276922 => 276923)
--- trunk/Tools/ChangeLog 2021-05-03 20:34:59 UTC (rev 276922)
+++ trunk/Tools/ChangeLog 2021-05-03 21:11:43 UTC (rev 276923)
@@ -1,3 +1,21 @@
+2021-05-03 Fujii Hironori <[email protected]>
+
+ REGRESSION(r275810): [WebKitTestRunner] fast/text/basic/004.html fails after running fast/layoutformattingcontext tests
+ https://bugs.webkit.org/show_bug.cgi?id=225087
+
+ Reviewed by Don Olmstead.
+
+ fast/layoutformattingcontext tests enable some internal debug
+ settings by using the test file header. These settings weren't
+ reset after running the tests.
+
+ r275810 changed resetPreferencesToConsistentValues not to call
+ WKPreferencesResetAllInternalDebugFeatures.
+
+ * WebKitTestRunner/TestController.cpp:
+ (WTR::TestController::resetPreferencesToConsistentValues):
+ Call WKPreferencesResetAllInternalDebugFeatures.
+
2021-05-03 Tim Nguyen <[email protected]>
Add committer status for "Tim Nguyen" in contributors.json
Modified: trunk/Tools/WebKitTestRunner/TestController.cpp (276922 => 276923)
--- trunk/Tools/WebKitTestRunner/TestController.cpp 2021-05-03 20:34:59 UTC (rev 276922)
+++ trunk/Tools/WebKitTestRunner/TestController.cpp 2021-05-03 21:11:43 UTC (rev 276923)
@@ -888,6 +888,8 @@
if (enableAllExperimentalFeatures)
WKPreferencesEnableAllExperimentalFeatures(preferences);
+ WKPreferencesResetAllInternalDebugFeatures(preferences);
+
WKPreferencesSetProcessSwapOnNavigationEnabled(preferences, options.shouldEnableProcessSwapOnNavigation());
WKPreferencesSetStorageBlockingPolicy(preferences, kWKAllowAllStorage); // FIXME: We should be testing the default.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
