Title: [276924] trunk/LayoutTests
- Revision
- 276924
- Author
- [email protected]
- Date
- 2021-05-03 14:21:59 -0700 (Mon, 03 May 2021)
Log Message
REGRESSION (r274461): [macOS wk1] fast/repaint/canvas-object-fit.html is flakey text failing
https://bugs.webkit.org/show_bug.cgi?id=223283
Reviewed by Ryosuke Niwa.
WK1 repaint tests are sensitive to the timing of paints, which are controlled by
WebViewLayerFlushScheduler layerFlushCallback() timing, which in turn is affected by the
state of -[NSWindow autodisplay], which DumpRenderTree sets to NO, but we flip to YES
when we see composited layers (which canvas triggers).
To avoid this fragile mess, have the test trigger compositing early on by making the 2D
canvas context, then wait for a frame before the repaint part of the test.
* fast/repaint/canvas-object-fit.html:
* platform/mac-wk1/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (276923 => 276924)
--- trunk/LayoutTests/ChangeLog 2021-05-03 21:11:43 UTC (rev 276923)
+++ trunk/LayoutTests/ChangeLog 2021-05-03 21:21:59 UTC (rev 276924)
@@ -1,3 +1,21 @@
+2021-05-03 Simon Fraser <[email protected]>
+
+ REGRESSION (r274461): [macOS wk1] fast/repaint/canvas-object-fit.html is flakey text failing
+ https://bugs.webkit.org/show_bug.cgi?id=223283
+
+ Reviewed by Ryosuke Niwa.
+
+ WK1 repaint tests are sensitive to the timing of paints, which are controlled by
+ WebViewLayerFlushScheduler layerFlushCallback() timing, which in turn is affected by the
+ state of -[NSWindow autodisplay], which DumpRenderTree sets to NO, but we flip to YES
+ when we see composited layers (which canvas triggers).
+
+ To avoid this fragile mess, have the test trigger compositing early on by making the 2D
+ canvas context, then wait for a frame before the repaint part of the test.
+
+ * fast/repaint/canvas-object-fit.html:
+ * platform/mac-wk1/TestExpectations:
+
2021-05-03 Truitt Savell <[email protected]>
[ Big Sur ] webrtc/video-vp8-videorange.html is faling on macmini8,1
Modified: trunk/LayoutTests/fast/repaint/canvas-object-fit.html (276923 => 276924)
--- trunk/LayoutTests/fast/repaint/canvas-object-fit.html 2021-05-03 21:11:43 UTC (rev 276923)
+++ trunk/LayoutTests/fast/repaint/canvas-object-fit.html 2021-05-03 21:21:59 UTC (rev 276924)
@@ -17,11 +17,7 @@
testRunner.waitUntilDone();
}
- var canvas = document.getElementById('canvas');
- var ctx = canvas.getContext('2d');
-
- ctx.fillStyle = "rgb(0, 128, 0)";
- ctx.fillRect(0, 0, 200, 200);
+ var ctx;
function repaintTest()
{
@@ -40,9 +36,15 @@
function startTest()
{
- setTimeout(function() {
+ var canvas = document.getElementById('canvas');
+ ctx = canvas.getContext('2d');
+
+ ctx.fillStyle = "rgb(0, 128, 0)";
+ ctx.fillRect(0, 0, 200, 200);
+
+ requestAnimationFrame(() => {
repaintTest();
- }, 0)
+ });
}
window.addEventListener('load', startTest, false);
</script>
Modified: trunk/LayoutTests/platform/mac-wk1/TestExpectations (276923 => 276924)
--- trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-05-03 21:11:43 UTC (rev 276923)
+++ trunk/LayoutTests/platform/mac-wk1/TestExpectations 2021-05-03 21:21:59 UTC (rev 276924)
@@ -1237,8 +1237,6 @@
webkit.org/b/223271 [ BigSur Debug ] imported/w3c/web-platform-tests/xhr/send-response-event-order.htm [ Pass Failure ]
-webkit.org/b/223283 fast/repaint/canvas-object-fit.html [ Pass Failure ]
-
webkit.org/b/222563 http/tests/loading/basic-auth-load-URL-with-consecutive-slashes.html [ Pass Failure ]
webkit.org/b/222686 imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-repeat-max-size-001.html [ Pass Failure ]
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
