Title: [277483] trunk/Source
- Revision
- 277483
- Author
- [email protected]
- Date
- 2021-05-13 22:53:12 -0700 (Thu, 13 May 2021)
Log Message
Misc GCC warning cleanup
https://bugs.webkit.org/show_bug.cgi?id=225777
Patch by Michael Catanzaro <[email protected]> on 2021-05-13
Reviewed by Carlos Garcia Campos.
Source/WebCore:
* bindings/js/JSAudioNodeCustom.cpp:
(WebCore::toJSNewlyCreated): Add missing RELEASE_ASSERT_NOT_REACHED().
* svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Remove redundant condition.
Source/WebDriver:
Remove unused variable.
* glib/WebDriverServiceGLib.cpp:
(WebDriver::parseVersion):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (277482 => 277483)
--- trunk/Source/WebCore/ChangeLog 2021-05-14 05:52:46 UTC (rev 277482)
+++ trunk/Source/WebCore/ChangeLog 2021-05-14 05:53:12 UTC (rev 277483)
@@ -1,3 +1,15 @@
+2021-05-13 Michael Catanzaro <[email protected]>
+
+ Misc GCC warning cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=225777
+
+ Reviewed by Carlos Garcia Campos.
+
+ * bindings/js/JSAudioNodeCustom.cpp:
+ (WebCore::toJSNewlyCreated): Add missing RELEASE_ASSERT_NOT_REACHED().
+ * svg/SVGToOTFFontConversion.cpp:
+ (WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Remove redundant condition.
+
2021-05-13 Carlos Garcia Campos <[email protected]>
[GTK] Wrong smooth animation sometimes with non-async scrolling
Modified: trunk/Source/WebCore/bindings/js/JSAudioNodeCustom.cpp (277482 => 277483)
--- trunk/Source/WebCore/bindings/js/JSAudioNodeCustom.cpp 2021-05-14 05:52:46 UTC (rev 277482)
+++ trunk/Source/WebCore/bindings/js/JSAudioNodeCustom.cpp 2021-05-14 05:53:12 UTC (rev 277483)
@@ -131,6 +131,7 @@
case AudioNode::NodeTypeWorklet:
return createWrapper<AudioWorkletNode>(globalObject, WTFMove(node));
}
+ RELEASE_ASSERT_NOT_REACHED();
}
JSValue toJS(JSGlobalObject* lexicalGlobalObject, JSDOMGlobalObject* globalObject, AudioNode& node)
Modified: trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp (277482 => 277483)
--- trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2021-05-14 05:52:46 UTC (rev 277482)
+++ trunk/Source/WebCore/svg/SVGToOTFFontConversion.cpp 2021-05-14 05:53:12 UTC (rev 277483)
@@ -1451,7 +1451,7 @@
m_weight = 7;
break;
}
- if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value >= 0 && *value < 1000) {
+ if (auto value = parseIntegerAllowingTrailingJunk<uint16_t>(segment); value && *value < 1000) {
m_weight = (*value + 50) / 100;
break;
}
Modified: trunk/Source/WebDriver/ChangeLog (277482 => 277483)
--- trunk/Source/WebDriver/ChangeLog 2021-05-14 05:52:46 UTC (rev 277482)
+++ trunk/Source/WebDriver/ChangeLog 2021-05-14 05:53:12 UTC (rev 277483)
@@ -1,3 +1,15 @@
+2021-05-13 Michael Catanzaro <[email protected]>
+
+ Misc GCC warning cleanup
+ https://bugs.webkit.org/show_bug.cgi?id=225777
+
+ Reviewed by Carlos Garcia Campos.
+
+ Remove unused variable.
+
+ * glib/WebDriverServiceGLib.cpp:
+ (WebDriver::parseVersion):
+
2021-05-13 Darin Adler <[email protected]>
Remove StringBuilder::appendNumber
Modified: trunk/Source/WebDriver/glib/WebDriverServiceGLib.cpp (277482 => 277483)
--- trunk/Source/WebDriver/glib/WebDriverServiceGLib.cpp 2021-05-14 05:52:46 UTC (rev 277482)
+++ trunk/Source/WebDriver/glib/WebDriverServiceGLib.cpp 2021-05-14 05:53:12 UTC (rev 277483)
@@ -35,7 +35,6 @@
major = minor = micro = 0;
Vector<String> tokens = version.split('.');
- bool ok;
switch (tokens.size()) {
case 3: {
auto parsedMicro = parseIntegerAllowingTrailingJunk<uint64_t>(tokens[2]);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
