Title: [277484] trunk
- Revision
- 277484
- Author
- [email protected]
- Date
- 2021-05-13 23:42:35 -0700 (Thu, 13 May 2021)
Log Message
Check for null element in paintSearchFieldResultsButton
https://bugs.webkit.org/show_bug.cgi?id=225232
Patch by Rob Buis <[email protected]> on 2021-05-13
Reviewed by Ryosuke Niwa.
Source/WebCore:
Check for null element in paintSearchFieldResultsButton.
Test: fast/css/searchfield-results-button-crash.html
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
LayoutTests:
Add test for this.
* fast/css/searchfield-results-button-crash-expected.txt: Added.
* fast/css/searchfield-results-button-crash.html: Added.
Modified Paths
Added Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (277483 => 277484)
--- trunk/LayoutTests/ChangeLog 2021-05-14 05:53:12 UTC (rev 277483)
+++ trunk/LayoutTests/ChangeLog 2021-05-14 06:42:35 UTC (rev 277484)
@@ -1,3 +1,15 @@
+2021-05-13 Rob Buis <[email protected]>
+
+ Check for null element in paintSearchFieldResultsButton
+ https://bugs.webkit.org/show_bug.cgi?id=225232
+
+ Reviewed by Ryosuke Niwa.
+
+ Add test for this.
+
+ * fast/css/searchfield-results-button-crash-expected.txt: Added.
+ * fast/css/searchfield-results-button-crash.html: Added.
+
2021-05-13 Lauro Moura <[email protected]>
[GTK] Skip WebXR tests after r277468
Added: trunk/LayoutTests/fast/css/searchfield-results-button-crash-expected.txt (0 => 277484)
--- trunk/LayoutTests/fast/css/searchfield-results-button-crash-expected.txt (rev 0)
+++ trunk/LayoutTests/fast/css/searchfield-results-button-crash-expected.txt 2021-05-14 06:42:35 UTC (rev 277484)
@@ -0,0 +1 @@
+PASS. WebKit didn't crash.
Added: trunk/LayoutTests/fast/css/searchfield-results-button-crash.html (0 => 277484)
--- trunk/LayoutTests/fast/css/searchfield-results-button-crash.html (rev 0)
+++ trunk/LayoutTests/fast/css/searchfield-results-button-crash.html 2021-05-14 06:42:35 UTC (rev 277484)
@@ -0,0 +1,8 @@
+PASS. WebKit didn't crash.
+<style>
+body:first-letter { float:left;-webkit-appearance: searchfield-results-button; }
+</style>
+<script>
+if (window.testRunner)
+ testRunner.dumpAsText();
+</script>
Modified: trunk/Source/WebCore/ChangeLog (277483 => 277484)
--- trunk/Source/WebCore/ChangeLog 2021-05-14 05:53:12 UTC (rev 277483)
+++ trunk/Source/WebCore/ChangeLog 2021-05-14 06:42:35 UTC (rev 277484)
@@ -1,3 +1,17 @@
+2021-05-13 Rob Buis <[email protected]>
+
+ Check for null element in paintSearchFieldResultsButton
+ https://bugs.webkit.org/show_bug.cgi?id=225232
+
+ Reviewed by Ryosuke Niwa.
+
+ Check for null element in paintSearchFieldResultsButton.
+
+ Test: fast/css/searchfield-results-button-crash.html
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
+
2021-05-13 Michael Catanzaro <[email protected]>
Misc GCC warning cleanup
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (277483 => 277484)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2021-05-14 05:53:12 UTC (rev 277483)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2021-05-14 06:42:35 UTC (rev 277484)
@@ -2041,6 +2041,8 @@
return adjustedLocalBounds;
};
+ if (!box.element())
+ return false;
Element* input = box.element()->shadowHost();
if (!input)
input = box.element();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
