Title: [279367] trunk/Source/WebKit
Revision
279367
Author
[email protected]
Date
2021-06-29 00:59:59 -0700 (Tue, 29 Jun 2021)

Log Message

[GTK][WPE] Bubblewrap: allow to set DBus proxy logging per proxy
https://bugs.webkit.org/show_bug.cgi?id=227447

Reviewed by Michael Catanzaro.

It's currently global using env var WEBKIT_ENABLE_DBUS_PROXY_LOGGING. Add WEBKIT_ENABLE_A11Y_DBUS_PROXY_LOGGING
to enable logging only on a11y bus.

* UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
(WebKit::XDGDBusProxyLauncher::launch):
(WebKit::bindA11y):
(WebKit::bubblewrapSpawn):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (279366 => 279367)


--- trunk/Source/WebKit/ChangeLog	2021-06-29 07:25:11 UTC (rev 279366)
+++ trunk/Source/WebKit/ChangeLog	2021-06-29 07:59:59 UTC (rev 279367)
@@ -1,3 +1,18 @@
+2021-06-29  Carlos Garcia Campos  <[email protected]>
+
+        [GTK][WPE] Bubblewrap: allow to set DBus proxy logging per proxy
+        https://bugs.webkit.org/show_bug.cgi?id=227447
+
+        Reviewed by Michael Catanzaro.
+
+        It's currently global using env var WEBKIT_ENABLE_DBUS_PROXY_LOGGING. Add WEBKIT_ENABLE_A11Y_DBUS_PROXY_LOGGING
+        to enable logging only on a11y bus.
+
+        * UIProcess/Launcher/glib/BubblewrapLauncher.cpp:
+        (WebKit::XDGDBusProxyLauncher::launch):
+        (WebKit::bindA11y):
+        (WebKit::bubblewrapSpawn):
+
 2021-06-29  Youenn Fablet  <[email protected]>
 
         Remove RemoteAudioMediaStreamTrackRenderer and RemoteAudioMediaStreamTrackRendererManager

Modified: trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp (279366 => 279367)


--- trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-06-29 07:25:11 UTC (rev 279366)
+++ trunk/Source/WebKit/UIProcess/Launcher/glib/BubblewrapLauncher.cpp	2021-06-29 07:59:59 UTC (rev 279367)
@@ -182,7 +182,7 @@
         m_permissions = WTFMove(permissions);
     };
 
-    void launch()
+    void launch(bool enableLogging)
     {
         RELEASE_ASSERT_WITH_SECURITY_IMPLICATION(!isRunning());
 
@@ -202,7 +202,7 @@
             syncFdStr.get(),
         };
 
-        if (!g_strcmp0(g_getenv("WEBKIT_ENABLE_DBUS_PROXY_LOGGING"), "1"))
+        if (enableLogging)
             proxyArgs.append("--log");
 
         proxyArgs.appendVector(m_permissions);
@@ -504,7 +504,7 @@
             "--call=org.a11y.atspi.Registry=org.a11y.atspi.DeviceEventController.NotifyListenersAsync@/org/a11y/atspi/registry/deviceeventcontroller",
         });
 
-        proxy.launch();
+        proxy.launch(!g_strcmp0(g_getenv("WEBKIT_ENABLE_A11Y_DBUS_PROXY_LOGGING"), "1"));
     }
 
     if (proxy.proxyPath().data()) {
@@ -890,7 +890,7 @@
                 permissions.append("--talk=org.freedesktop.portal.Desktop");
             }
             proxy.setPermissions(WTFMove(permissions));
-            proxy.launch();
+            proxy.launch(!g_strcmp0(g_getenv("WEBKIT_ENABLE_DBUS_PROXY_LOGGING"), "1"));
         }
     } else {
         // Only X11 users need this for XShm which is only the Web process.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to