Title: [279368] trunk/Source/WebCore
Revision
279368
Author
[email protected]
Date
2021-06-29 01:11:24 -0700 (Tue, 29 Jun 2021)

Log Message

OES_texture_float should implicitly enable EXT_float_blend
https://bugs.webkit.org/show_bug.cgi?id=227456
<rdar://79804439>

Patch by Kimmo Kinnunen <[email protected]> on 2021-06-29
Reviewed by Kenneth Russell.

Tested by webgl/1.0.x/conformance/extensions/oes-texture-float.html

* html/canvas/OESTextureFloat.cpp:
(WebCore::OESTextureFloat::OESTextureFloat):
Request EXT_float_blend when user requests OES_texture_float.
WEBGL_color_buffer_float and EXT_color_buffer_float already have
the code.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (279367 => 279368)


--- trunk/Source/WebCore/ChangeLog	2021-06-29 07:59:59 UTC (rev 279367)
+++ trunk/Source/WebCore/ChangeLog	2021-06-29 08:11:24 UTC (rev 279368)
@@ -1,3 +1,19 @@
+2021-06-29  Kimmo Kinnunen  <[email protected]>
+
+        OES_texture_float should implicitly enable EXT_float_blend
+        https://bugs.webkit.org/show_bug.cgi?id=227456
+        <rdar://79804439>
+
+        Reviewed by Kenneth Russell.
+
+        Tested by webgl/1.0.x/conformance/extensions/oes-texture-float.html
+
+        * html/canvas/OESTextureFloat.cpp:
+        (WebCore::OESTextureFloat::OESTextureFloat):
+        Request EXT_float_blend when user requests OES_texture_float.
+        WEBGL_color_buffer_float and EXT_color_buffer_float already have
+        the code.
+
 2021-06-29  Youenn Fablet  <[email protected]>
 
         Remove RemoteAudioMediaStreamTrackRenderer and RemoteAudioMediaStreamTrackRendererManager

Modified: trunk/Source/WebCore/html/canvas/OESTextureFloat.cpp (279367 => 279368)


--- trunk/Source/WebCore/html/canvas/OESTextureFloat.cpp	2021-06-29 07:59:59 UTC (rev 279367)
+++ trunk/Source/WebCore/html/canvas/OESTextureFloat.cpp	2021-06-29 08:11:24 UTC (rev 279368)
@@ -41,6 +41,9 @@
     context.graphicsContextGL()->getExtensions().ensureEnabled("GL_OES_texture_float"_s);
     context.graphicsContextGL()->getExtensions().ensureEnabled("GL_CHROMIUM_color_buffer_float_rgb"_s);
     context.graphicsContextGL()->getExtensions().ensureEnabled("GL_CHROMIUM_color_buffer_float_rgba"_s);
+    // https://github.com/KhronosGroup/WebGL/pull/2830
+    // Spec requires EXT_float_blend to be turned on implicitly here.
+    context.graphicsContextGL()->getExtensions().ensureEnabled("GL_EXT_float_blend"_s);
 }
 
 OESTextureFloat::~OESTextureFloat() = default;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to