Title: [280218] trunk/LayoutTests
- Revision
- 280218
- Author
- [email protected]
- Date
- 2021-07-23 00:30:57 -0700 (Fri, 23 Jul 2021)
Log Message
Removed incorrect test from webgl tests.
https://bugs.webkit.org/show_bug.cgi?id=220720
Patch by Eleni Maria Stea <[email protected]> on 2021-07-23
Reviewed by Kenneth Russell.
The removed test was based on the incorrect assumption that
deleted buffer names remain valid until the object they used to
refer to is destroyed. According to the WebGL spec:
https://www.khronos.org/registry/webgl/specs/1.0.3/ section:
5.14.5 isBuffer "Return false if the buffer's invalidated flag
is set", this is not true and names become invalid immediately.
* fast/canvas/webgl/oes-vertex-array-object.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (280217 => 280218)
--- trunk/LayoutTests/ChangeLog 2021-07-23 03:20:56 UTC (rev 280217)
+++ trunk/LayoutTests/ChangeLog 2021-07-23 07:30:57 UTC (rev 280218)
@@ -1,3 +1,19 @@
+2021-07-23 Eleni Maria Stea <[email protected]>
+
+ Removed incorrect test from webgl tests.
+ https://bugs.webkit.org/show_bug.cgi?id=220720
+
+ Reviewed by Kenneth Russell.
+
+ The removed test was based on the incorrect assumption that
+ deleted buffer names remain valid until the object they used to
+ refer to is destroyed. According to the WebGL spec:
+ https://www.khronos.org/registry/webgl/specs/1.0.3/ section:
+ 5.14.5 isBuffer "Return false if the buffer's invalidated flag
+ is set", this is not true and names become invalid immediately.
+
+ * fast/canvas/webgl/oes-vertex-array-object.html:
+
2021-07-22 Robert Jenner <[email protected]>
Batch add test expectations for Monterey on Open Source
Modified: trunk/LayoutTests/fast/canvas/webgl/oes-vertex-array-object.html (280217 => 280218)
--- trunk/LayoutTests/fast/canvas/webgl/oes-vertex-array-object.html 2021-07-23 03:20:56 UTC (rev 280217)
+++ trunk/LayoutTests/fast/canvas/webgl/oes-vertex-array-object.html 2021-07-23 07:30:57 UTC (rev 280218)
@@ -478,10 +478,6 @@
for (var ii = 0; ii < colorBuffers.length; ++ii) {
gl.deleteBuffer(colorBuffers[ii]);
gl.deleteBuffer(elementBuffers[ii]);
- // The buffers should still be valid at this point, since it was attached to the VAO
- if(!gl.isBuffer(colorBuffers[ii])) {
- testFailed("buffer removed too early");
- }
}
gl.deleteBuffer(positionBuffer);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
