Title: [281533] trunk/Source/WebCore
Revision
281533
Author
[email protected]
Date
2021-08-24 17:07:26 -0700 (Tue, 24 Aug 2021)

Log Message

MediaSession artwork URL is showing in logs.
https://bugs.webkit.org/show_bug.cgi?id=229320
rdar://82156288

Reviewed by Eric Carlson.

Only enable artwork logging in debug builds.

* platform/audio/cocoa/MediaSessionManagerCocoa.mm:
(WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (281532 => 281533)


--- trunk/Source/WebCore/ChangeLog	2021-08-25 00:03:01 UTC (rev 281532)
+++ trunk/Source/WebCore/ChangeLog	2021-08-25 00:07:26 UTC (rev 281533)
@@ -1,3 +1,16 @@
+2021-08-24  Jean-Yves Avenard  <[email protected]>
+
+        MediaSession artwork URL is showing in logs.
+        https://bugs.webkit.org/show_bug.cgi?id=229320
+        rdar://82156288
+
+        Reviewed by Eric Carlson.
+
+        Only enable artwork logging in debug builds.
+
+        * platform/audio/cocoa/MediaSessionManagerCocoa.mm:
+        (WebCore::MediaSessionManagerCocoa::updateNowPlayingInfo):
+
 2021-08-24  Chris Dumez  <[email protected]>
 
         change event is dispatched when .files property is set at <input type="file"> element

Modified: trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm (281532 => 281533)


--- trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2021-08-25 00:03:01 UTC (rev 281532)
+++ trunk/Source/WebCore/platform/audio/cocoa/MediaSessionManagerCocoa.mm	2021-08-25 00:07:26 UTC (rev 281533)
@@ -392,9 +392,16 @@
 
     m_haveEverRegisteredAsNowPlayingApplication = true;
 
-    if (m_nowPlayingManager->setNowPlayingInfo(*nowPlayingInfo))
-        ALWAYS_LOG(LOGIDENTIFIER, "title = \"", nowPlayingInfo->title, "\", isPlaying = ", nowPlayingInfo->isPlaying, ", duration = ", nowPlayingInfo->duration, ", now = ", nowPlayingInfo->currentTime, ", id = ", nowPlayingInfo->uniqueIdentifier.toUInt64(), ", registered = ", m_registeredAsNowPlayingApplication, ", src = "" nowPlayingInfo->artwork ? nowPlayingInfo->artwork->src : String(), "\"");
-
+    if (m_nowPlayingManager->setNowPlayingInfo(*nowPlayingInfo)) {
+#ifdef LOG_DISABLED
+        String src = ""
+        String title = "title";
+#else
+        String src = "" ? nowPlayingInfo->artwork->src : String();
+        String title = nowPlayingInfo->title;
+#endif
+        ALWAYS_LOG(LOGIDENTIFIER, "title = \"", title, "\", isPlaying = ", nowPlayingInfo->isPlaying, ", duration = ", nowPlayingInfo->duration, ", now = ", nowPlayingInfo->currentTime, ", id = ", nowPlayingInfo->uniqueIdentifier.toUInt64(), ", registered = ", m_registeredAsNowPlayingApplication, ", src = "" src, "\"");
+    }
     if (!m_registeredAsNowPlayingApplication) {
         m_registeredAsNowPlayingApplication = true;
         providePresentingApplicationPIDIfNecessary();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to