Title: [281534] trunk/Source/_javascript_Core
- Revision
- 281534
- Author
- [email protected]
- Date
- 2021-08-24 17:08:00 -0700 (Tue, 24 Aug 2021)
Log Message
testb3_6 should be using JSSwitchPtrTag instead of JITCompilationPtrTag.
https://bugs.webkit.org/show_bug.cgi?id=229479
rdar://82316967
Reviewed by Yusuke Suzuki.
This is in testInterpreter() which is emitting code for a jump table.
JSSwitchPtrTag is the right tag to use here.
* b3/testb3_6.cpp:
(testInterpreter):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (281533 => 281534)
--- trunk/Source/_javascript_Core/ChangeLog 2021-08-25 00:07:26 UTC (rev 281533)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-08-25 00:08:00 UTC (rev 281534)
@@ -1,3 +1,17 @@
+2021-08-24 Mark Lam <[email protected]>
+
+ testb3_6 should be using JSSwitchPtrTag instead of JITCompilationPtrTag.
+ https://bugs.webkit.org/show_bug.cgi?id=229479
+ rdar://82316967
+
+ Reviewed by Yusuke Suzuki.
+
+ This is in testInterpreter() which is emitting code for a jump table.
+ JSSwitchPtrTag is the right tag to use here.
+
+ * b3/testb3_6.cpp:
+ (testInterpreter):
+
2021-08-24 Keith Miller <[email protected]>
Add for-in OwnStructureMode optimizations to LLInt
Modified: trunk/Source/_javascript_Core/b3/testb3_6.cpp (281533 => 281534)
--- trunk/Source/_javascript_Core/b3/testb3_6.cpp 2021-08-25 00:07:26 UTC (rev 281533)
+++ trunk/Source/_javascript_Core/b3/testb3_6.cpp 2021-08-25 00:08:00 UTC (rev 281534)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2015-2020 Apple Inc. All rights reserved.
+ * Copyright (C) 2015-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -1677,19 +1677,19 @@
AllowMacroScratchRegisterUsage allowScratch(jit);
Vector<Box<CCallHelpers::Label>> labels = params.successorLabels();
- MacroAssemblerCodePtr<JITCompilationPtrTag>* jumpTable = bitwise_cast<MacroAssemblerCodePtr<JITCompilationPtrTag>*>(
- params.proc().addDataSection(sizeof(MacroAssemblerCodePtr<JITCompilationPtrTag>) * labels.size()));
+ MacroAssemblerCodePtr<JSSwitchPtrTag>* jumpTable = bitwise_cast<MacroAssemblerCodePtr<JSSwitchPtrTag>*>(
+ params.proc().addDataSection(sizeof(MacroAssemblerCodePtr<JSSwitchPtrTag>) * labels.size()));
GPRReg scratch = params.gpScratch(0);
jit.move(CCallHelpers::TrustedImmPtr(jumpTable), scratch);
jit.load64(CCallHelpers::BaseIndex(scratch, params[0].gpr(), CCallHelpers::ScalePtr), scratch);
- jit.farJump(scratch, JITCompilationPtrTag);
+ jit.farJump(scratch, JSSwitchPtrTag);
jit.addLinkTask(
[&, jumpTable, labels] (LinkBuffer& linkBuffer) {
for (unsigned i = labels.size(); i--;)
- jumpTable[i] = linkBuffer.locationOf<JITCompilationPtrTag>(*labels[i]);
+ jumpTable[i] = linkBuffer.locationOf<JSSwitchPtrTag>(*labels[i]);
});
});
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
