Title: [282642] releases/WebKitGTK/webkit-2.32/Source/WebCore
- Revision
- 282642
- Author
- [email protected]
- Date
- 2021-09-17 01:29:10 -0700 (Fri, 17 Sep 2021)
Log Message
Merge r281813 - REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)
https://bugs.webkit.org/show_bug.cgi?id=229680
<rdar://problem/82541045>
Reviewed by Darin Adler.
The page is inserting new children to shadow host and on each insertion we are traversing the composed
tree to tear down renderers, even though there are none.
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):
If the host doesn't have a renderer or 'display:contents' there can't be any renderers left in the subtree.
Modified Paths
Diff
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog (282641 => 282642)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-17 08:29:06 UTC (rev 282641)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog 2021-09-17 08:29:10 UTC (rev 282642)
@@ -1,3 +1,19 @@
+2021-08-31 Antti Koivisto <[email protected]>
+
+ REGRESSION (r272900): wpt.fyi loading performance is very slow (regressed, and slower than other browsers)
+ https://bugs.webkit.org/show_bug.cgi?id=229680
+ <rdar://problem/82541045>
+
+ Reviewed by Darin Adler.
+
+ The page is inserting new children to shadow host and on each insertion we are traversing the composed
+ tree to tear down renderers, even though there are none.
+
+ * rendering/updating/RenderTreeUpdater.cpp:
+ (WebCore::RenderTreeUpdater::tearDownRenderersAfterSlotChange):
+
+ If the host doesn't have a renderer or 'display:contents' there can't be any renderers left in the subtree.
+
2021-08-16 Antti Koivisto <[email protected]>
REGRESSION (r275756): Accelerated animations freeze when invalidating layout with shadow dom
Modified: releases/WebKitGTK/webkit-2.32/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp (282641 => 282642)
--- releases/WebKitGTK/webkit-2.32/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp 2021-09-17 08:29:06 UTC (rev 282641)
+++ releases/WebKitGTK/webkit-2.32/Source/WebCore/rendering/updating/RenderTreeUpdater.cpp 2021-09-17 08:29:10 UTC (rev 282642)
@@ -539,6 +539,8 @@
void RenderTreeUpdater::tearDownRenderersAfterSlotChange(Element& host)
{
ASSERT(host.shadowRoot());
+ if (!host.renderer() && !host.hasDisplayContents())
+ return;
auto* view = host.document().renderView();
if (!view)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
